Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic log text for points reactions #478

Open
JDGrimes opened this issue Aug 18, 2016 · 5 comments
Open

Dynamic log text for points reactions #478

JDGrimes opened this issue Aug 18, 2016 · 5 comments
Milestone

Comments

@JDGrimes
Copy link
Member

@JDGrimes JDGrimes commented Aug 18, 2016

Previously: WordPoints/hooks-api#8

The idea is that we should be able to include the post title or other information in a reaction's log text dynamically at fire time, similar to how the old points hooks used to work. But in this case we'd take the template text from the reaction settings, and substitute in the values for placeholders. Idea is that we'd also have a UI feature that would make the placeholders magical.

@JDGrimes JDGrimes added this to the 2.3.0 milestone Nov 15, 2016
@JDGrimes
Copy link
Member Author

@JDGrimes JDGrimes commented Nov 26, 2016

This should be a more generic feature of the hooks API that we just utilize for this particular setting, perhaps.

@JDGrimes JDGrimes mentioned this issue Dec 9, 2016
1 of 13 tasks complete
@JDGrimes
Copy link
Member Author

@JDGrimes JDGrimes commented Dec 10, 2016

Before we can do this, we will need a way to integrate with the entity restriction API. #541 introduced that API with support for restrictions for entity children, and even a restriction for post content of protected posts (though of course post content is generally unlikely to be included in the points logs). However, we'll need to have the ability to detect when a reaction relates to a restricted entity, so that we can restrict logs for that reaction accordingly. That will require a new API for getting a list of all entities and children a reaction relates to. Or, we could just detect whether the event relates to any args that are restricted, regardless of whether the reaction actually references them, although that is more restrictive than necessary, and wouldn't have applications beyond this particular use.

@JDGrimes
Copy link
Member Author

@JDGrimes JDGrimes commented Feb 18, 2017

I've been thinking that really, we could go ahead and introduce the API for this on the back-end, and then add a UI for it later. In the mean time it would just be more of a power-user feature. I just don't think that we should hold up the whole thing just because we're wrestling to find the right UI for it.

@JDGrimes
Copy link
Member Author

@JDGrimes JDGrimes commented Feb 23, 2017

I guess actually, this could maybe be abstracted to be an extension of the entities API that is just utilized by the hooks API.

@JDGrimes JDGrimes modified the milestones: 2.4.0, 2.3.0 Feb 25, 2017
@JDGrimes
Copy link
Member Author

@JDGrimes JDGrimes commented Jul 1, 2017

One thing that has specifically been requested is to link to the comment/post.

For example “comment on post” when clicked, it directs to the comment.

Also “Comment on Post” under the Description section of the Points Logs table is unclickable. It would be great if I can do the same thing. When clicked on the phrase, it directs to the the post where the user adds a comment. With this option, I can keep track of or view where users add comments.

@JDGrimes JDGrimes modified the milestones: 2.4.0, 2.5.0 Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant