New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Enable the `ControlStructures.ControlSignature.NewlineAfterOpenBrace` check #987

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
2 participants
@jrfnl
Contributor

jrfnl commented Jun 20, 2017

See #971 (comment)

This was originally disabled in #366 as being too finicky, but fixes issues we are now running into with the WP coding standards update.

Fixes #971
Fixes #974

Core: Enable the `ControlStructures.ControlSignature.NewlineAfterOpen…
…Brace` check

This was originally disabled in 366 as being too finicky, but fixes issues we are now running into with the WP coding standards update.

Fixes 971
Fixes 974
@JDGrimes

This comment has been minimized.

Show comment
Hide comment
@JDGrimes

JDGrimes Jun 20, 2017

Contributor

The reason that I added this exclusion is because I often add a blank line after a control structure's opening brace. I just find this to be more readable. Of course, I could add this exclusion in my custom ruleset if needed if it is removed here.

Actually though, running this sniff over my code without the exclusion doesn't seem to report issues any longer, so perhaps it has been improved. Let's go ahead and remove the exclusion.

Contributor

JDGrimes commented Jun 20, 2017

The reason that I added this exclusion is because I often add a blank line after a control structure's opening brace. I just find this to be more readable. Of course, I could add this exclusion in my custom ruleset if needed if it is removed here.

Actually though, running this sniff over my code without the exclusion doesn't seem to report issues any longer, so perhaps it has been improved. Let's go ahead and remove the exclusion.

@JDGrimes JDGrimes added this to the 0.12.0 milestone Jun 20, 2017

@JDGrimes JDGrimes merged commit f62195d into develop Jun 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JDGrimes JDGrimes deleted the feature/fix-971-974-inline-control-structures branch Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment