Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Handbook Overhaul] Patterns > Introduction to Patterns #1478

Closed
Tracked by #816
justintadlock opened this issue Mar 5, 2024 · 10 comments
Closed
Tracked by #816

[Theme Handbook Overhaul] Patterns > Introduction to Patterns #1478

justintadlock opened this issue Mar 5, 2024 · 10 comments
Assignees
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook

Comments

@justintadlock
Copy link

This ticket is a part of #816 and will be used for creating new page titled "Introduction to Patterns" under the "Patterns" chapter.

The content for the new page will be drafted in a Google Doc: https://docs.google.com/document/d/1LdDb-yMxZ6I-EPbM-UtrXOXrqH9oBarnbwOpd-eFYEU/edit?usp=sharing

@justintadlock justintadlock added developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. themes Issues for Theme Developer Handbook labels Mar 5, 2024
@justintadlock justintadlock self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Heads up @kafleg @carolinan @TeBenachi - the "themes" label was applied to this issue.

Copy link

github-actions bot commented Mar 5, 2024

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@justintadlock
Copy link
Author

The first draft for this doc is finished and can now be reviewed.

@carolinan
Copy link
Collaborator

The difficult part here is how to describe the difference between a synced and not synced pattern, -and decided what to call the not synced patterns. Lets make sure the name or phrase is the same in the editor UI, developer documentation, and user documentation (I did not look it up).

Parts of the description and screenshots are only for block themes. The pattern creation is not the same in classic themes and block themes.
It probably will be the same from WordPress 6.6.

@justintadlock
Copy link
Author

Thanks for the review. I've went through and addressed each of the points.

The difficult part here is how to describe the difference between a synced and not synced pattern, -and decided what to call the not synced patterns. Lets make sure the name or phrase is the same in the editor UI, developer documentation, and user documentation (I did not look it up).

I changed this to Synced and Not synced, which is what is shown in the UI for WordPress 6.5.

It does bug me when describing this because the English word for "not synced" should be "unsynced." But it's best to go with what's in the UI for consistency.

@kafleg
Copy link
Member

kafleg commented Apr 2, 2024

What about mentioning copying patterns from patterns directory and paste in the post/page or site editor?

@justintadlock
Copy link
Author

What about mentioning copying patterns from patterns directory and paste in the post/page or site editor?

I'd think that's more of a user feature and not specifically relevant to developing a theme.

The theme method of integrating with the Pattern Directory would be to include them in theme.json, which is covered here: https://developer.wordpress.org/themes/global-settings-and-styles/patterns/

@kafleg
Copy link
Member

kafleg commented Apr 12, 2024

Looks good.

@justintadlock
Copy link
Author

The draft for this has been moved to the handbook: https://developer.wordpress.org/wp-admin/post.php?post=153618&action=edit

@justintadlock
Copy link
Author

@github-actions github-actions bot added the [Status] Done Issue is completed label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer documentation (DevHub) Improvements or additions to developer documentation new document Requests for new page/article. [Status] Done Issue is completed themes Issues for Theme Developer Handbook
Projects
None yet
Development

No branches or pull requests

3 participants