Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our tests (round 2) #170

Merged
merged 10 commits into from Oct 2, 2015
Merged

Improve our tests (round 2) #170

merged 10 commits into from Oct 2, 2015

Conversation

@rmccue
Copy link
Collaborator

@rmccue rmccue commented Oct 2, 2015

Massive props to @ozh for his work on #149. Also changed the Portquiz test to use regex instead, since we don't care if the page is valid HTML or not.

ozh and others added 3 commits Oct 2, 2015
This will save **260** outgoing queries to httpbin.org
DOMDocument is prone to crashing with HTML errors, and since we only
care about this tiny bit, might as well use a simpler regex.
@rmccue rmccue added this to the 1.7 milestone Oct 2, 2015
@rmccue rmccue mentioned this pull request Oct 2, 2015
rmccue added a commit that referenced this issue Oct 2, 2015
@rmccue rmccue merged commit 94a3423 into master Oct 2, 2015
3 checks passed
Loading
@rmccue rmccue deleted the fix-tests-damn-it branch Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants