Skip to content

Exception\Transport\Curl: add perfunctory unit tests #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 2 commits into from
Sep 23, 2021
Merged

Exception\Transport\Curl: add perfunctory unit tests #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa34cdc
Exception\Transport\Curl: add perfunctory unit tests
jrfnl Sep 2, 2021
e94251f
Exception\Transport\Curl: minor fix
jrfnl Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception/Transport/Curl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function __construct($message, $type, $data = null, $code = 0) {
}

if ($code !== null) {
$this->code = $code;
$this->code = (int) $code;
}

if ($message !== null) {
Expand Down
129 changes: 129 additions & 0 deletions tests/Exception/Transport/CurlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
<?php

namespace WpOrg\Requests\Tests\Exception\Transport;

use WpOrg\Requests\Exception\Transport\Curl;
use WpOrg\Requests\Tests\TestCase;

/**
* @covers \WpOrg\Requests\Exception\Transport\Curl
*/
final class CurlTest extends TestCase {

/**
* Test that the error message is set correctly.
*
* @dataProvider dataException
*
* @param string $expected_msg Expected error message.
* @param int $expected_code Expected error code.
* @param string $expected_reason Expected error reason.
* @param string $message Exception message.
* @param string $type Exception type.
* @param mixed $data Optional. Associated data, if applicable.
* @param int $code Optional. Exception numerical code.
*
* @return void
*/
public function testException(
$expected_msg,
$expected_code,
$expected_reason,
$message,
$type,
$data = null,
$code = 0
) {
$this->expectException(Curl::class);
$this->expectExceptionMessage($expected_msg);
$this->expectExceptionCode($expected_code);

$exception = new Curl($message, $type, $data, $code);

$this->assertSame($expected_reason, $exception->getReason());

throw $exception;
}

/**
* Data provider.
*
* @return array
*/
public function dataException() {
return array(
'Everything set to null (or not passed)' => array(
'expected_msg' => '-1 Unknown',
'expected_code' => -1,
'expected_reason' => 'Unknown',
'message' => null,
'type' => null,
'data' => null,
'code' => null,
),
'Message passed, everything else set to null (or not passed)' => array(
'expected_msg' => '-1 testing-1-2-3',
'expected_code' => -1,
'expected_reason' => 'testing-1-2-3',
'message' => 'testing-1-2-3',
'type' => null,
'data' => null,
'code' => null,
),
'Type passed, everything else set to null (or not passed)' => array(
'expected_msg' => '-1 Unknown',
'expected_code' => -1,
'expected_reason' => 'Unknown',
'message' => null,
'type' => Curl::EASY,
'data' => null,
'code' => null,
),
'Code passed, everything else set to null (or not passed)' => array(
'expected_msg' => CURLE_COULDNT_RESOLVE_HOST . ' Unknown',
'expected_code' => CURLE_COULDNT_RESOLVE_HOST,
'expected_reason' => 'Unknown',
'message' => null,
'type' => null,
'data' => null,
'code' => CURLE_COULDNT_RESOLVE_HOST,
),
'Message and type passed, everything else set to null (or not passed)' => array(
'expected_msg' => '-1 testing-1-2-3',
'expected_code' => -1,
'expected_reason' => 'testing-1-2-3',
'message' => 'testing-1-2-3',
'type' => Curl::EASY,
'data' => null,
'code' => null,
),
'Message and code passed, everything else set to null (or not passed)' => array(
'expected_msg' => CURLE_COULDNT_RESOLVE_HOST . ' testing-1-2-3',
'expected_code' => CURLE_COULDNT_RESOLVE_HOST,
'expected_reason' => 'testing-1-2-3',
'message' => 'testing-1-2-3',
'type' => null,
'data' => null,
'code' => CURLE_COULDNT_RESOLVE_HOST,
),
'Type and code passed, everything else set to null (or not passed)' => array(
'expected_msg' => CURLE_COULDNT_RESOLVE_HOST . ' Unknown',
'expected_code' => CURLE_COULDNT_RESOLVE_HOST,
'expected_reason' => 'Unknown',
'message' => null,
'type' => Curl::EASY,
'data' => null,
'code' => CURLE_COULDNT_RESOLVE_HOST,
),
'Everything set; code not integer' => array(
'expected_msg' => '61 testing-1-2-3',
'expected_code' => 61,
'expected_reason' => 'testing-1-2-3',
'message' => 'testing-1-2-3',
'type' => Curl::EASY,
'data' => array(),
'code' => '61 text',
),
);
}
}