Skip to content
Permalink
Browse files

General: PHP7.3 throws an `E_WARNING` when using continue to target a…

… switch

Applying continue to a switch is equivalent to using break and quite possibly, a continue targeting a higher level control structure is actually intended.

To target the higher level control structure, a numeric argument has to be passed to continue. This fixes two cases in WordPress Core where this is currently happening.

See: php/php-src#3364
See: https://wiki.php.net/rfc/continue_on_switch_deprecation

Props jrf.
Fixes #44543.


Built from https://develop.svn.wordpress.org/trunk@43653


git-svn-id: http://core.svn.wordpress.org/trunk@43482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information...
aaronjorbin committed Sep 23, 2018
1 parent 0929610 commit 76ef0432c0ce8f560c9bf474fa52314697f7da68
Showing with 2 additions and 2 deletions.
  1. +1 −1 wp-includes/pomo/plural-forms.php
  2. +1 −1 wp-includes/version.php
@@ -207,7 +207,7 @@ protected function parse( $str ) {
$span = strspn( $str, self::NUM_CHARS, $pos );
$output[] = array( 'value', intval( substr( $str, $pos, $span ) ) );
$pos += $span;
continue;
break;
}
throw new Exception( sprintf( 'Unknown symbol "%s"', $next ) );
@@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.0-alpha-43652';
$wp_version = '5.0-alpha-43653';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.

1 comment on commit 76ef043

@jojodimaandal

This comment has been minimized.

Copy link

jojodimaandal commented on 76ef043 Sep 24, 2018

Good day,

I tried to reflect all the instructions which was provided. Please find attached.
Post category to be displayed in front page · Pull Request #379 · WordPress.pdf

Thank you.

Please sign in to comment.
You can’t perform that action at this time.