From fe6b65c44b929ee5583f6146d92388ef43061f9a Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 12 May 2023 08:51:22 +0000 Subject: [PATCH] Code Modernization: Explicitly declare all properties in `Text_Diff_Engine_native`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it is an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in. * For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. In this case, the properties, as used in the class methods, fall in the “known property” category. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [53942], [53948], [53949], [53952], [53953], [53954], [53957], [54037]. Props jrf, thomask. See #58298. Built from https://develop.svn.wordpress.org/trunk@55752 git-svn-id: http://core.svn.wordpress.org/trunk@55264 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/Text/Diff/Engine/native.php | 10 ++++++++++ wp-includes/version.php | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/wp-includes/Text/Diff/Engine/native.php b/wp-includes/Text/Diff/Engine/native.php index e6fa9758a3bd..b3d8441a583d 100644 --- a/wp-includes/Text/Diff/Engine/native.php +++ b/wp-includes/Text/Diff/Engine/native.php @@ -28,6 +28,16 @@ */ class Text_Diff_Engine_native { + public $xchanged; + public $ychanged; + public $xv; + public $yv; + public $xind; + public $yind; + public $seq; + public $in_seq; + public $lcs; + function diff($from_lines, $to_lines) { array_walk($from_lines, array('Text_Diff', 'trimNewlines')); diff --git a/wp-includes/version.php b/wp-includes/version.php index 5d7b5b6f032f..3acc77e064a3 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.3-alpha-55751'; +$wp_version = '6.3-alpha-55752'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.