Skip to content
Permalink
Branch: master
Commits on Jun 18, 2019
  1. Plugins: When validating plugin's WordPress and PHP requirements, che…

    SergeyBiryukov committed Jun 18, 2019
    …ck for `Requires at least` and `Requires PHP` headers in the plugin's main PHP file.
    
    This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.
    
    If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.
    
    Props afragen, Otto42, Ipstenu.
    Fixes #46938.
    Built from https://develop.svn.wordpress.org/trunk@45546
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 17, 2019
  1. Bootstrap/Load: Set expiration of the recovery mode cookie to the sam…

    SergeyBiryukov committed Jun 17, 2019
    …e amount of time for which the token in it is valid: a week by default.
    
    Props david.binda, TimothyBlynJacobs.
    Fixes #47480.
    Built from https://develop.svn.wordpress.org/trunk@45545
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Bootstrap/Load: Return a 403 error code when the recovery mode cookie…

    SergeyBiryukov committed Jun 17, 2019
    … is invalid or expired, or the exit recovery mode nonce check failed.
    
    Props david.binda, spacedmonkey.
    Fixes #47479.
    Built from https://develop.svn.wordpress.org/trunk@45544
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 16, 2019
  1. Media: Ignore errors coming from `image_resize_dimensions()` when cre…

    azaozz committed Jun 16, 2019
    …ating sub-sizes (for now). It returns `false` when the requested size is larger than the original image and should be skipped. This triggers new `WP_Error` in `WP_Image_Editor::resize()`.
    
    See #40439.
    Built from https://develop.svn.wordpress.org/trunk@45543
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 15, 2019
  1. I18N: Merge duplicate strings in notifications displayed when a new u…

    SergeyBiryukov committed Jun 15, 2019
    …ser has been created or added to the site.
    
    Props ramiy.
    Fixes #35746.
    Built from https://develop.svn.wordpress.org/trunk@45542
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Media: fix support for arrays for the `crop` setting for registered i…

    azaozz committed Jun 15, 2019
    …mage sub-sizes in `wp_get_registered_image_subsizes()`.
    
    See #40439.
    Built from https://develop.svn.wordpress.org/trunk@45541
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. After [45538]: fix another WPCS "strict comparison" fix.

    azaozz committed Jun 15, 2019
    Props birgire.
    See #40439.
    Built from https://develop.svn.wordpress.org/trunk@45540
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Save progress of intermediate image creation after upload. First run.

    azaozz committed Jun 15, 2019
    - Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
    - Adds a way to display errors that happened while creating sub-sizes.
    - Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.
    
    Note that the patch also includes some unrelated WPCS fixes.
    
    Props mikeschroder, azaozz.
    See #40439.
    Built from https://develop.svn.wordpress.org/trunk@45538
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 14, 2019
  1. Menus: Set better default for `$args` parameter in `Walker_Nav_Menu` …

    SergeyBiryukov committed Jun 14, 2019
    …methods, to match the documented parameter type.
    
    Props trasweb.
    Fixes #47524.
    Built from https://develop.svn.wordpress.org/trunk@45537
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Administration: Adjust code for "Manage widgets or menus" item on "We…

    SergeyBiryukov committed Jun 14, 2019
    …lcome to WordPress" panel to avoid an extra space after [42343].
    
    Props Presskopp, davidbaumwald.
    Fixes #47536.
    Built from https://develop.svn.wordpress.org/trunk@45536
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 13, 2019
  1. Docs: Fix typos in `Services_JSON` DocBlocks.

    desrosj committed Jun 13, 2019
    Props mukesh27.
    Fixes #47401.
    Built from https://develop.svn.wordpress.org/trunk@45535
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Fix displaying of the "An updated version of WordPress is available."…

    azaozz committed Jun 13, 2019
    … notice when running the latest nightly build. Note that it is still displayed when running a local build or from `/src`.
    
    Props afragen, audrasjb, SergeyBiryukov.
    Fixes #45202.
    Built from https://develop.svn.wordpress.org/trunk@45532
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Accessibility: Handle one more case of focus loss when switching view…

    afercia committed Jun 13, 2019
    … in the Media Views.
    
    See #43169.
    
    Built from https://develop.svn.wordpress.org/trunk@45531
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Add a Recovery Mode Exit button to the notice. This fixes it in respo…

    azaozz committed Jun 13, 2019
    …nsive view.
    
    Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
    Fixes #47070.
    Built from https://develop.svn.wordpress.org/trunk@45529
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  5. Customize: Remove “Update” link for themes on multisite installs.

    desrosj committed Jun 13, 2019
    In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.
    
    This removes that update link because updates cannot actually be performed in the Customizer in this situation.
    
    Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
    Fixes #46997.
    Built from https://develop.svn.wordpress.org/trunk@45527
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  6. Media: Make sure the bottom media toolbar content is fully visible wi…

    afercia committed Jun 13, 2019
    …th Internet Explorer 11.
    
    Props mspatovaliyski.
    Fixes #47502.
    
    Built from https://develop.svn.wordpress.org/trunk@45526
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 12, 2019
  1. Bundled Theme: Fix malformed Google Font URL for Twenty Twelve due to…

    westonruter committed Jun 12, 2019
    … double-encoding of `+`
    
    Amends [45485].
    Fixes #47282.
    
    Built from https://develop.svn.wordpress.org/trunk@45525
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Accessibility: Improve focus management in the Media Views.

    afercia committed Jun 12, 2019
    - keeps focus management only where necessary to avoid focus losses
    - removes focus management where a specific user workflow was assumed
    - makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
    - adds inline comments to clarify all the usages of focus()
    
    Fixes #43169.
    
    Built from https://develop.svn.wordpress.org/trunk@45524
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Administration: Improve the horizontal centering of the Site Health t…

    afercia committed Jun 12, 2019
    …abs.
    
    Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
    Fixes #46881.
    
    Built from https://develop.svn.wordpress.org/trunk@45522
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Administration: Fix the responsive layout after changes to the Screen…

    afercia committed Jun 12, 2019
    … Options and Help buttons position.
    
    Fixes #45094.
    
    Built from https://develop.svn.wordpress.org/trunk@45520
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 10, 2019
  1. Privacy tools:

    azaozz committed Jun 10, 2019
    - Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
    - Move the `WP_User_Request` class to a separate file.
    
    See #43895.
    Built from https://develop.svn.wordpress.org/trunk@45519
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. I18N: Merge duplicate "authenticity could not be verified" strings, f…

    SergeyBiryukov committed Jun 10, 2019
    …ix comma placement on About page.
    
    Props pedromendonca, garrett-eclipse.
    Fixes #47475.
    Built from https://develop.svn.wordpress.org/trunk@45515
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Site health: Introduce `view_site_health_checks` capability.

    peterwilsoncc committed Jun 10, 2019
    Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.
    
    The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.
    
    The capability is granted on the `user_has_cap` filter.
    
    Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
    Fixes #46957.
    
    
    Built from https://develop.svn.wordpress.org/trunk@45507
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 9, 2019
  1. Accessibility: Fix the order of the Previous, Next, and Close buttons…

    afercia committed Jun 9, 2019
    … in the Attachment Details modal.
    
    Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.
    
    Fixes #47458.
    
    Built from https://develop.svn.wordpress.org/trunk@45506
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 8, 2019
  1. I18N: Allow the length of automatically generated excerpts to be loca…

    johnbillion committed Jun 8, 2019
    …lized.
    
    This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.
    
    Props miyauchi, birgire, johnbillion
    
    Fixes #44541
    
    Built from https://develop.svn.wordpress.org/trunk@45505
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. HTTP API: Ensure the `http_api_debug` hook is fired for all responses.

    johnbillion committed Jun 8, 2019
    This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.
    
    Fixes #25747
    
    Built from https://develop.svn.wordpress.org/trunk@45504
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Accessibility: Improve the Screen Options and Help buttons order.

    afercia committed Jun 8, 2019
    - makes the buttons visual order match the DOM order
    - also, restores the focus style on the "hero" primary button after [34948]
    
    Props vrimill, mukesh27 for reporting and testing.
    Fixes #45094.
    
    Built from https://develop.svn.wordpress.org/trunk@45503
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Administration: Improve the Screen Options and Help buttons focus sty…

    afercia committed Jun 8, 2019
    …le after [45501].
    
    Amends [45501].
    See #46749.
    
    Built from https://develop.svn.wordpress.org/trunk@45502
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  5. Administration: Remove extra border from the Screen Options and Help …

    afercia committed Jun 8, 2019
    …buttons.
    
    The extra border was visible in the responsive view for smaller screens after [32844].
    
    Props jitendrabanjara1991.
    Fixes #46749.
    
    Built from https://develop.svn.wordpress.org/trunk@45501
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 7, 2019
  1. Accessibility: Improve accessibility of all the media views form cont…

    afercia committed Jun 7, 2019
    …rols.
    
    - changes the media views form controls to have explicitly associated labels with for/id attributes
    - adds a few missing labels / aria-labels
    - improves a few existing labels / aria-labels
    - improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
    - improves the image custom size input fields and their labelling
    - adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
    - swaps the columns source order in the image details template, to make visual and DOM order match
    - swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
    - gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
    - merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
    - makes the "upload-ui" consistent across the media views
    - hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
    - adds comments to all the media templates to clarify their usage
    - slightly increases vertical spacing between form fields in the media sidebar
    - removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
    - removes some CSS still targeting Internet Explorer 7 and 8
    
    Fixes #47141.
    Fixes #47122.
    
    Built from https://develop.svn.wordpress.org/trunk@45499
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Regenerate the REST API fixtures after [45443].

    afercia committed Jun 7, 2019
    See #38517.
    
    Built from https://develop.svn.wordpress.org/trunk@45498
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Fix the media player controls bar width in the media views.

    afercia committed Jun 7, 2019
    Props vaishalipanchal, chetan200891.
    Fixes #47457.
    
    Built from https://develop.svn.wordpress.org/trunk@45497
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Jun 6, 2019
  1. Docs: Fix typo in `comment_class()` DocBlock.

    SergeyBiryukov committed Jun 6, 2019
    Props mbabker.
    Fixes #47499.
    Built from https://develop.svn.wordpress.org/trunk@45496
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@45307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Older
You can’t perform that action at this time.