Permalink
Commits on Sep 23, 2018
  1. General: PHP7.3 throws an `E_WARNING` when using continue to target a…

    aaronjorbin committed Sep 23, 2018
    … switch
    
    Applying continue to a switch is equivalent to using break and quite possibly, a continue targeting a higher level control structure is actually intended.
    
    To target the higher level control structure, a numeric argument has to be passed to continue. This fixes two cases in WordPress Core where this is currently happening.
    
    See: php/php-src#3364
    See: https://wiki.php.net/rfc/continue_on_switch_deprecation
    
    Props jrf.
    Fixes #44543.
    
    
    Built from https://develop.svn.wordpress.org/trunk@43653
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Tests: Add missing `public` access modifier to `Tests_REST_Server` me…

    SergeyBiryukov committed Sep 23, 2018
    …thods.
    
    Props andizer.
    Fixes #44939.
    Built from https://develop.svn.wordpress.org/trunk@43652
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Users: Add `LIMIT 1` to SQL query in `WP_User::get_data_by()`, as onl…

    SergeyBiryukov committed Sep 23, 2018
    …y one row is requested.
    
    Props spacedmonkey.
    Fixes #43692.
    Built from https://develop.svn.wordpress.org/trunk@43651
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 20, 2018
  1. Upgrade/Install: Adjust table prefix string check in `setup-config.ph…

    SergeyBiryukov committed Sep 20, 2018
    …p` for the coding standards change in [42343].
    
    Props shashwatmittal, allendav.
    Fixes #44318.
    Built from https://develop.svn.wordpress.org/trunk@43650
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 18, 2018
Commits on Sep 15, 2018
  1. Build/Test Tools: Implement the automatic retry functionality that Tr…

    johnbillion committed Sep 15, 2018
    …avis CI provides.
    
    This functionality will cause the command to be retried up to three times in case of a non-zero return value. Implementing it on commands that perform network requests means that intermittent network failures are less likely to cause a build to fail, as they'll be retried up to three times.
    
    See #44858
    
    Built from https://develop.svn.wordpress.org/trunk@43645
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 14, 2018
  1. Docs: Improve docblocks within `wp-login.php`.

    johnbillion committed Sep 14, 2018
    Props birgire
    
    See #42505
    
    Built from https://develop.svn.wordpress.org/trunk@43644
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Docs: Correct and improve docblocks for user session management funct…

    johnbillion committed Sep 14, 2018
    …ionality.
    
    See #42505
    
    Built from https://develop.svn.wordpress.org/trunk@43643
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Docs: Correct and improve some docblocks.

    johnbillion committed Sep 14, 2018
    See #42505
    
    Built from https://develop.svn.wordpress.org/trunk@43642
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Upgrade/Install: Properly exclude the `admin/includesSchema.php` test…

    felixarntz committed Sep 14, 2018
    …s file for the `WordPress.DB.PreparedSQL.NotPrepared` sniff.
    
    The way this was implemented in [43630] caused the file to be excluded for all sniffs, since PHPCS does not support file-wide ignores of a specific sniff at this point.
    
    Props jrf.
    See #44896.
    
    Built from https://develop.svn.wordpress.org/trunk@43641
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 13, 2018
  1. Privacy: Add test for `wp_privacy_export_expiration` filter.

    iandunn committed Sep 13, 2018
    Props desrosj.
    See #44233.
    
    Built from https://develop.svn.wordpress.org/trunk@43640
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Docs: Correct `@SInCE` value for `_wp_privacy_statuses()`.

    SergeyBiryukov committed Sep 13, 2018
    Fix typo in `@SInCE` entry for `WP_Privacy_Policy_Content:add()`.
    
    Props dimadin.
    Fixes #44915.
    Built from https://develop.svn.wordpress.org/trunk@43638
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 12, 2018
  1. REST API: Pass correct ID to `meta->update_value` to permit setting t…

    kadamwhite committed Sep 12, 2018
    …erm meta during term creation.
    
    Props joehoyle.
    Fixes #44834.
    
    
    Built from https://develop.svn.wordpress.org/trunk@43636
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. I18N: In the POMO library, replace `chr()` calls for static values wi…

    ocean90 committed Sep 12, 2018
    …th their string representation.
    
    Props ccismaru, ocean90.
    Fixes #17128.
    Built from https://develop.svn.wordpress.org/trunk@43635
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 8, 2018
  1. Media: Improve display and accessibility of meta data in detail view.

    adamsilverstein committed Sep 8, 2018
    * Add a `human_readable_duration` function including tests.
    * Add 'pixels' after image width/height.
    * Add screen reader text for durations.
    
    Props Presskopp, kiranpotphode, milindmore22, stormrockwell, afercia.
    Fixes #39667. 
    
    
    Built from https://develop.svn.wordpress.org/trunk@43633
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 6, 2018
  1. Docs: Update `@SInCE` version for `(un)registered_taxonomy_for_object…

    SergeyBiryukov committed Sep 6, 2018
    …_type` actions introduced in [43558].
    
    See #44733.
    Built from https://develop.svn.wordpress.org/trunk@43631
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 5, 2018
  1. Upgrade/Install: Introduce `populate_site_meta()`.

    felixarntz committed Sep 5, 2018
    Fixes #44896. See #41333.
    
    Built from https://develop.svn.wordpress.org/trunk@43629
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Upgrade/Install: Introduce `populate_network_meta()`, moving logic ou…

    felixarntz committed Sep 5, 2018
    …t of `populate_network()`.
    
    Fixes #44895. See #41333.
    
    Built from https://develop.svn.wordpress.org/trunk@43628
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Upgrade/Install: Add support for an optional `$options` parameter to …

    felixarntz committed Sep 5, 2018
    …`populate_options()`.
    
    Fixes #44893. See #41333.
    
    Built from https://develop.svn.wordpress.org/trunk@43627
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 3, 2018
  1. Privacy: When clicking a confirmation link for a privacy request, ret…

    SergeyBiryukov committed Sep 3, 2018
    …urn a `WP_Error` object if the link has expired.
    
    Returning a string caused a success message to be displayed instead of the correct error message.
    
    Props desrosj.
    Fixes #44685.
    Built from https://develop.svn.wordpress.org/trunk@43623
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. Docs: Update `@SInCE` version for `edit_post_{$post->post_type}` acti…

    SergeyBiryukov committed Sep 3, 2018
    …on introduced in [43535] to 4.9.9.
    
    See #34706.
    Built from https://develop.svn.wordpress.org/trunk@43616
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Docs: Correct parameter type for `WP_Privacy_Policy_Content::notice()`.

    SergeyBiryukov committed Sep 3, 2018
    Props burhandodhy.
    Fixes #44877.
    Built from https://develop.svn.wordpress.org/trunk@43609
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. Cron API: Clarify documentation for `wp_reschedule_event()`.

    peterwilsoncc committed Sep 3, 2018
    Expands documentation to indicate `wp_schedule_event()` ought to be used for rescheduling an upcoming event, while `wp_reschedule_event()` is used for internally rescheduling a recurring event after it runs.
    
    Props Dharm1025, jrf.
    Fixes #35968.
    
    
    Built from https://develop.svn.wordpress.org/trunk@43608
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  5. Twenty Sixteen: Add pre-connect resource hint for Google Fonts.

    peterwilsoncc committed Sep 3, 2018
    When using Google Fonts, pre-connect to https://fonts.gstatic.com to improve the performance downloading the webfont files.
    
    Props westonruter.
    Fixes #44668.
    
    Built from https://develop.svn.wordpress.org/trunk@43606
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Sep 2, 2018
  1. Taxonomy: Make sure `wp_list_categories()` correctly outputs term nam…

    SergeyBiryukov committed Sep 2, 2018
    …e of `0`.
    
    Props joyously, SergeyBiryukov.
    Fixes #44872.
    Built from https://develop.svn.wordpress.org/trunk@43605
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Aug 31, 2018
  1. REST API: Load missing required file for multisite users in `WP_REST_…

    rachelbaker committed Aug 31, 2018
    …Attachments_Controller::create_item()`.
    
    Requires wp-admin/includes/image.php to make `wp_read_image_metadata()` function available. Fixes error introduced in [43589].
    
    Props ocean90, soulseekah.
    Fixes #43757.
    Built from https://develop.svn.wordpress.org/trunk@43604
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. REST API: Load missing required file for multisite users in `WP_REST_…

    rachelbaker committed Aug 31, 2018
    …Attachments_Controller::check_upload_size()`.
    
    Requires wp-admin/includes/ms.php to make `upload_is_user_over_quota()` function available to multisite users uploading files.
    
    Props JakePT, rachelbaker.
    Fixes #44864.
    Built from https://develop.svn.wordpress.org/trunk@43603
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Media: Ensure the "Edit more details" link in the attachment details …

    johnbillion committed Aug 31, 2018
    …modal always points to the correct editing URL.
    
    Fixes #44620
    
    Built from https://develop.svn.wordpress.org/trunk@43601
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Commits on Aug 30, 2018
  1. Docs: Convert `@see` reference in `wp_checkdate()` DocBlock to `@link`.

    SergeyBiryukov committed Aug 30, 2018
    Props WiZZarD_.
    Fixes #44866.
    Built from https://develop.svn.wordpress.org/trunk@43599
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  2. I18n: Improve translators comments [3].

    jrfnl committed Aug 30, 2018
    * Add missing translators comments.
    * Fix placement of some translators comments.
      Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
      The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.
    
    Includes minor code layout fixes.
    
    Patch `44360-wp-admin-includes-dir.patch` of the series.
    
    Props flipkeijzer, alvarogois, michielatyoast
    See #44360
    
    Built from https://develop.svn.wordpress.org/trunk@43598
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  3. Embeds: After [43593], move the new check to a separate line to avoid…

    SergeyBiryukov committed Aug 30, 2018
    … `test_js_no_ampersands_in_compiled` failure caused by UglifyJS task.
    
    See #44832.
    Built from https://develop.svn.wordpress.org/trunk@43597
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  4. I18n: Improve translators comments [2].

    jrfnl committed Aug 30, 2018
    * Add missing translators comments.
    * Fix placement of some translators comments.
      Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
      The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.
    
    Patch `44360.wp-includes_customize.3.patch` of the series.
    
    Props marcomartins, mihaiiceyro, michielatyoast
    See #44360
    
    Built from https://develop.svn.wordpress.org/trunk@43596
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  5. I18n: Improve translators comments [1].

    jrfnl committed Aug 30, 2018
    * Add missing translators comments.
    * Fix placement of some translators comments.
      Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
      The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.
    
    Patch `44360-src.2.diff` of the series.
    
    Props garyj, alvarogois, michielatyoast
    See #44360
    Built from https://develop.svn.wordpress.org/trunk@43595
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@43424 1a063a9b-81f0-0310-95a4-ce76da25c4cd