New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where Wordpress tries to unnecessarily set the memory limit #26

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@peterjaap

peterjaap commented Jan 21, 2013

Fixed bug where Wordpress tries to unnecessarily set the memory limit when a value like '2G' is used instead of '2048M'.

Discovered by willemo and PeterJaap

Peter Jaap Blaakmeer added some commits Jan 21, 2013

Peter Jaap Blaakmeer
Fixed bug where Wordpress tries to unnecessarily set the memory limit…
… when a value like '2G' is used instead of '2048M'
Peter Jaap Blaakmeer
Fixed bug where Wordpress tries to unnecessarily set the memory limit…
… when a value like '2G' is used instead of '2048M'
@ctalkington

This comment has been minimized.

Show comment
Hide comment
@ctalkington

ctalkington Jan 21, 2013

im not sure that PRs are monitored here. this is a mirror of the SVN.

ctalkington commented Jan 21, 2013

im not sure that PRs are monitored here. this is a mirror of the SVN.

@amyunus

This comment has been minimized.

Show comment
Hide comment
@amyunus

amyunus Jan 23, 2013

Of course they aren't. It is clear on description
Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead.

amyunus commented Jan 23, 2013

Of course they aren't. It is clear on description
Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead.

@peterjaap

This comment has been minimized.

Show comment
Hide comment
@peterjaap

peterjaap Jan 23, 2013

... which sucks. Git ftw.

peterjaap commented Jan 23, 2013

... which sucks. Git ftw.

@chaseadamsio

This comment has been minimized.

Show comment
Hide comment
@chaseadamsio

chaseadamsio Jan 23, 2013

This isn't an issue with git, rather an issue of understanding how to request patch submission. If you're interested in having a patch or contribution merged into the WordPress use: http://core.trac.wordpress.org/

Also, it's generally a good practice to read any readme's and descriptions (ie: WordPress, Git-ified. Synced via SVN every 15 minutes, including branches and tags! This repository is just a mirror of the WordPress subversion repository. Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead.) associated with a project before getting started with it.

On Jan 23, 2013, at 7:57 AM, Peter Jaap Blaakmeer notifications@github.com wrote:

... which sucks. Git ftw.


Reply to this email directly or view it on GitHub.

chaseadamsio commented Jan 23, 2013

This isn't an issue with git, rather an issue of understanding how to request patch submission. If you're interested in having a patch or contribution merged into the WordPress use: http://core.trac.wordpress.org/

Also, it's generally a good practice to read any readme's and descriptions (ie: WordPress, Git-ified. Synced via SVN every 15 minutes, including branches and tags! This repository is just a mirror of the WordPress subversion repository. Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead.) associated with a project before getting started with it.

On Jan 23, 2013, at 7:57 AM, Peter Jaap Blaakmeer notifications@github.com wrote:

... which sucks. Git ftw.


Reply to this email directly or view it on GitHub.

@peterjaap

This comment has been minimized.

Show comment
Hide comment
@peterjaap

peterjaap Jan 23, 2013

I get that, but I can't see why WP won't migrate to Git (and preferably Github) altogether. Drupal has done it.

peterjaap commented Jan 23, 2013

I get that, but I can't see why WP won't migrate to Git (and preferably Github) altogether. Drupal has done it.

@technosailor

This comment has been minimized.

Show comment
Hide comment
@technosailor

technosailor Jan 23, 2013

WordPress is not Drupal. And WordPress uses SVN. End of story. You want to
do core dev, you use SVN. Period. Next?

Aaron Brazell
WordPress Consultant
Author, WordPress Bible

e. aaron@technosailor.com
b. technosailor.com
t. http://twitter.com/technosailor
p. 512-2AARON2

On Wed, Jan 23, 2013 at 11:07 AM, Peter Jaap Blaakmeer <
notifications@github.com> wrote:

I get that, but I can't see why WP won't migrate to Git (and preferably
Github) altogether. Drupal has done it.


Reply to this email directly or view it on GitHubhttps://github.com/WordPress/WordPress/pull/26#issuecomment-12602493.

technosailor commented Jan 23, 2013

WordPress is not Drupal. And WordPress uses SVN. End of story. You want to
do core dev, you use SVN. Period. Next?

Aaron Brazell
WordPress Consultant
Author, WordPress Bible

e. aaron@technosailor.com
b. technosailor.com
t. http://twitter.com/technosailor
p. 512-2AARON2

On Wed, Jan 23, 2013 at 11:07 AM, Peter Jaap Blaakmeer <
notifications@github.com> wrote:

I get that, but I can't see why WP won't migrate to Git (and preferably
Github) altogether. Drupal has done it.


Reply to this email directly or view it on GitHubhttps://github.com/WordPress/WordPress/pull/26#issuecomment-12602493.

@nacin

This comment has been minimized.

Show comment
Hide comment
@nacin

nacin Jan 23, 2013

Member

Well, you don't actually need to use SVN to contribute to WordPress. If you wanted to use Git, you could. You simply need to follow our patch submission process. Here's an article on how to contribute to WordPress using GitHub.

Member

nacin commented Jan 23, 2013

Well, you don't actually need to use SVN to contribute to WordPress. If you wanted to use Git, you could. You simply need to follow our patch submission process. Here's an article on how to contribute to WordPress using GitHub.

@nacin nacin closed this Jan 23, 2013

@mustafauysal mustafauysal referenced this pull request Feb 4, 2013

Closed

3gp mime support added! #27

bdolly pushed a commit to bdolly/paperTheme that referenced this pull request Oct 18, 2014

Merge pull request #26 from SimpliZine/patch-1
Add missing attribute assignment equals sign, props SimpliZine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment