This repository has been archived by the owner. It is now read-only.

A way to link the customizer code editor with the edit themes/plugins editor #17

Closed
paaljoachim opened this Issue Aug 1, 2017 · 6 comments

Comments

3 participants
@paaljoachim

paaljoachim commented Aug 1, 2017

At the beginning of a brainstorm...

We have two edit areas.
In the edit screen for editing plugins and themes and the Additional CSS in the customizer.
I am thinking there should be a way to create a link between these areas. As one can edit CSS in both places. This means the user can add some CSS to the style.css of the theme and some CSS to the CSS area in the customizer.

I got to think about this some more....

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Aug 1, 2017

Member

@paaljoachim I suggest that there should be a notice added when opening the theme editor, to have a deep-link to the Additional CSS section in the Customizer.

Such a notice already appears, somewhat, in the plugin editor:

image

Something should be done like when opening the old admin-based header/background admin pages:

image

Member

westonruter commented Aug 1, 2017

@paaljoachim I suggest that there should be a notice added when opening the theme editor, to have a deep-link to the Additional CSS section in the Customizer.

Such a notice already appears, somewhat, in the plugin editor:

image

Something should be done like when opening the old admin-based header/background admin pages:

image

@westonruter westonruter modified the milestone: 4.9 Aug 7, 2017

@melchoyce melchoyce self-assigned this Aug 23, 2017

@melchoyce melchoyce modified the milestone: 4.9 Aug 24, 2017

@melchoyce melchoyce added this to In progress in 4.9 Aug 24, 2017

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Aug 25, 2017

Member

@melchoyce could you source some design and language for notices to display on the theme and plugin editors to display persistently on both?

Also, could you provide direction for how we should style the Update File button when there are reported linting errors? Maybe there should be a checkbox to confirm? Or an old-school confirm dialog?

Member

westonruter commented Aug 25, 2017

@melchoyce could you source some design and language for notices to display on the theme and plugin editors to display persistently on both?

Also, could you provide direction for how we should style the Update File button when there are reported linting errors? Maybe there should be a checkbox to confirm? Or an old-school confirm dialog?

@melchoyce

This comment has been minimized.

Show comment
Hide comment
@melchoyce

melchoyce Aug 25, 2017

Collaborator

@melchoyce could you source some design and language for notices to display on the theme and plugin editors to display persistently on both?

Conveniently enough, I worked on that today :) That conversation is over in https://core.trac.wordpress.org/ticket/31779, though I'd love to merge these two somehow. @helen, would you have any interest in working on these notices in GitHub, or would you prefer to stay on Trac and in SVN?

Also, could you provide direction for how we should style the Update File button when there are reported linting errors? Maybe there should be a checkbox to confirm? Or an old-school confirm dialog?

Does CodeMirror distinguish at all between suggestions and errors? Wondering if we could block people from saving when they have errors, and give them some sort of warning when there are just suggestions.

Collaborator

melchoyce commented Aug 25, 2017

@melchoyce could you source some design and language for notices to display on the theme and plugin editors to display persistently on both?

Conveniently enough, I worked on that today :) That conversation is over in https://core.trac.wordpress.org/ticket/31779, though I'd love to merge these two somehow. @helen, would you have any interest in working on these notices in GitHub, or would you prefer to stay on Trac and in SVN?

Also, could you provide direction for how we should style the Update File button when there are reported linting errors? Maybe there should be a checkbox to confirm? Or an old-school confirm dialog?

Does CodeMirror distinguish at all between suggestions and errors? Wondering if we could block people from saving when they have errors, and give them some sort of warning when there are just suggestions.

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Aug 26, 2017

Member

@melchoyce

Conveniently enough, I worked on that today :) That conversation is over in https://core.trac.wordpress.org/ticket/31779, though I'd love to merge these two somehow.

Great! I was just going to ask about adding a link to Additional CSS in the Customizer, and I see you've accounted for that.

Does CodeMirror distinguish at all between suggestions and errors? Wondering if we could block people from saving when they have errors, and give them some sort of warning when there are just suggestions.

Yes, I believe we can block just in the case of errors.

Member

westonruter commented Aug 26, 2017

@melchoyce

Conveniently enough, I worked on that today :) That conversation is over in https://core.trac.wordpress.org/ticket/31779, though I'd love to merge these two somehow.

Great! I was just going to ask about adding a link to Additional CSS in the Customizer, and I see you've accounted for that.

Does CodeMirror distinguish at all between suggestions and errors? Wondering if we could block people from saving when they have errors, and give them some sort of warning when there are just suggestions.

Yes, I believe we can block just in the case of errors.

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Aug 30, 2017

Member

Yes, I believe we can block just in the case of errors.

This has been implemented in #49.

Member

westonruter commented Aug 30, 2017

Yes, I believe we can block just in the case of errors.

This has been implemented in #49.

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter
Member

westonruter commented Sep 13, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.