Skip to content
This repository has been archived by the owner. It is now read-only.

Editor width doesn't account for extra space #5

Closed
melchoyce opened this issue Jun 30, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@melchoyce
Copy link
Collaborator

commented Jun 30, 2017

The inclusion of the line numbers increases the overall width of the editor, so it cuts into the list of files on the side:

With:

image

Without:

image

The editor should remain the same width, with the line numbers taking up room inside, rather than outside.

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 13, 2017

@melchoyce melchoyce added the bug label Aug 2, 2017

@westonruter westonruter modified the milestone: 4.9 Aug 7, 2017

@westonruter

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

@melchoyce I don't think this is a problem. The main difference between the two editors, actually, is that CodeMirror does not wrap lines whereas a textarea does. We could enable lineWrapping option and that results in:

image

I'll also note that adding line-wrapping is a workaround fix for #32 as well.

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2017

Line-wrapping is good 👍 But the extra width is still a problem — notice in my before/after how the editor starts to run very close to the file list.

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2017

image

@westonruter

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

But the extra width is still a problem — notice in my before/after how the editor starts to run very close to the file list.

Oh I see now. Fixed in 74859d1 via #33.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.