Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Explorations: Error States #11

Open
melchoyce opened this issue Jul 10, 2019 · 17 comments

Comments

@melchoyce
Copy link
Collaborator

commented Jul 10, 2019

We need to figure out all the potential errors and where there can be points of failure:

  • Block can’t install (your internet craps out, etc.)
  • What happens if you don’t have permissions
  • What else?

Related: #8

@melchoyce melchoyce self-assigned this Jul 10, 2019

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

If we can't preview the block for some reason, like a WordPress.org outage:

image

@ck3lee do you know if we have existing error strings for something like this? If not, we'll want to write one.

If the installation fails (but the block can preview):

image


Is there any other point in this flow that might produce an error?

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

Permissions

If you don't have administrative permissions (or any custom permission that allows installation of new plugins), let's show the existing message for search results:

@boemedia

This comment has been minimized.

Copy link

commented Jul 11, 2019

In the last case, is it possible to show the blocks but greyed out, with a message saying:
"Your current role doesn't allow installing new blocks. Contact your website's administrator."

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Maybe like:

image

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

I like that as an option over having greyed out. I feel if we showed greyed out blocks it could taunt the user.

@ck-lee

This comment has been minimized.

Copy link

commented Jul 11, 2019

do you know if we have existing error strings for something like this?

No, I couldn't find any existing error strings. I only found a couple that are generic and technical like
The response is not a valid JSON response.. So, we might need to write them.

@ck-lee

This comment has been minimized.

Copy link

commented Jul 11, 2019

LGTM! I think the two scenarios: "can't preview the block" and "installation fails" should capture all the unexpected failure points. I will drop a comment here if I can think of anything else.

@ck-lee

This comment has been minimized.

Copy link

commented Jul 15, 2019

@melchoyce, I'm finding it very tricky to implement the actions in the notice bar. I am finding out more from the Gutenberg dev team now.

In case, it is a mission to add the actions like "Retry" or "Remove block", is it OK to remove them?

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

As long as we can add them to a later roadmap and follow up, I think it's okay to drop from the v1.

@ck-lee

This comment has been minimized.

Copy link

commented Jul 17, 2019

Thank you @melchoyce. Looks like we can do a "Retry". 😄

By default all "non-url actions" in the notice are rendered as buttons instead of links. I think it might be semantically more appropriate for a11y. But happy to re-style that as a link too.

Still a WIP. But here is what is looks like:
screencast 2019-07-18 10-55-16

@ck-lee

This comment has been minimized.

Copy link

commented Jul 17, 2019

And for user without permission to install a block.

This is how it looks like:

screencast 2019-07-18 10-57-12

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@melchoyce I wonder if the 'no blocks' could be an opportunity for a cute little graphic? Like a sad block. It's just an idea.

@karmatosed

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Just checking back on this, could it be in v1 to explore a little visual variation beyond text?

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Should we explore this in Gutenberg core? We're hooking in to the core "no results" pattern.

@karmatosed

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Sure, I will make issue for this also.

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Thanks, feel free to assign it to me.

@karmatosed

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@melchoyce WordPress/gutenberg#17122 is where started that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.