Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Explorations: Missing Blocks #12

Closed
melchoyce opened this issue Jul 10, 2019 · 7 comments

Comments

@melchoyce
Copy link
Collaborator

commented Jul 10, 2019

What happens if you’re missing a block, or import content with a block you don’t have installed?

Related: #8

@melchoyce melchoyce self-assigned this Jul 10, 2019

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

If the block is present in the Block Directory:

image

If it's not, we should probably leave as-is:

image

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Would creating a placeholder or style around this be nice? I am thinking of for example in Facebook when a page is loading the background color/style of those. My thinking is otherwise it gets lost, this may be a fix to have in Gutenberg itself.

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

If someone's added custom styles to their block, the block itself might display just fine on the front-end. With a shortcode, you'll also want to know what shortcode you'd added to that page. Because of this, we should still show whatever content they're trying to load in the editor instead of replacing it with a placeholder, IMO.

@ck-lee

This comment has been minimized.

Copy link

commented Jul 11, 2019

The design looks good to me!

From dev's perspective, I think it should be OK to render the "unsupported block" in the editor. I will try and see, including any custom styles. Will let you know...

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 12, 2019

FWIW, Gutenberg currently does render the content of the unsupported block — that's where that shortcode screenshot comes from. For example, here's the Block Gallery plugin, after being disabled:

image

@karmatosed

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Can you confirm @melchoyce this is now completed?

@melchoyce

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Unless anyone has more feedback, then yes 👍

@karmatosed karmatosed closed this Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.