Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix incorrect trash unicode address, and tweak build process #246
This PR intends to address regressions found as part of the attempt to merge the new icon font (as built by the grunt script) into 4.9. The full thread is here: https://core.trac.wordpress.org/ticket/41074, but a condensed task list is the following:
This PR addresses 4, 5, and partially addresses 3. 1 and 2 have to happen upstream.
It now includes a CSS template file, so we can better tweak the spacing and layout of the files. But it looks like we can't edit
I haven't found a way to adjust the order in which icons are output in the CSS file — it's done alphabetically. So I don't know that we can sort the CSS classes.
The trash icon issue seems to have been due to a file being renamed (see 8bd649b) without the codepoint also moving.
To add the extra markup, I edited the CSS template file.
So to summarize: this PR fixes the bugs that came with the build process and makes the CSS files better adhere to WP standards. But it does not (can't) go all the way to be a 100% drop-in replacement.
I think just the same as the were, to make comparisons easier, see: https://core.trac.wordpress.org/timeline?from=2017-10-25T07%3A13%3A27%2B02%3A00&precision=second
Manual updating is very error prone, so I would suggest we only do that as exceptions.
Also, I don't think we can ever get the built files to match the style of the old file. I'm fact I'm not sure we can ever get any closer than we are in this PR. As such it may be good to make this as one big change, get it done, and then have an easier and less error prone future. Just make sure to test thoroughly.