Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a unique text-domain, wporg-5ftf #110

Merged
merged 7 commits into from Nov 23, 2019

Conversation

@audrasjb
Copy link
Contributor

audrasjb commented Nov 23, 2019

Hi,

In this PR, let's edit the various text-domains used on 5ftf theme and plugins.
For reference: #25 (comment)
Fixes #25

Jb added 2 commits Nov 23, 2019
Jb Jb
Copy link
Contributor

ryelle left a comment

Thanks for fixing these (too 🙂 )

Can you also update the rule in phpcs.xml.dist? Once you do that, you'll see there are still 3 files with issues:

  • plugins/wporg-5ftf/includes/pledge-form.php
  • themes/wporg-5ftf/template-parts/content-5ftf_pledge.php
  • themes/wporg-5ftf/single-5ftf_pledge.php

If you can fix those, I'll merge this PR 👍 (I'm also happy to take over, just let me know)

@audrasjb

This comment has been minimized.

Copy link
Contributor Author

audrasjb commented Nov 23, 2019

Thanks @ryelle !
I updated the PR. I don't think I missed anything… but CI checks failed 😬

@audrasjb

This comment has been minimized.

Copy link
Contributor Author

audrasjb commented Nov 23, 2019

Hm, looks like it's because of type="array" in:

<rule ref="WordPress.WP.I18n">
	<properties>
		<property name="text_domain" type="array" value="wporg-5ftf" />
	</properties>
</rule>
Jb added 2 commits Nov 23, 2019
Jb Jb
Jb Jb
@audrasjb

This comment has been minimized.

Copy link
Contributor Author

audrasjb commented Nov 23, 2019

Ok, it's not related to my changes 😊

Jb added 2 commits Nov 23, 2019
Jb Jb
Jb Jb
@audrasjb

This comment has been minimized.

Copy link
Contributor Author

audrasjb commented Nov 23, 2019

Travis is happy now ^^

@ryelle
ryelle approved these changes Nov 23, 2019
Copy link
Contributor

ryelle left a comment

looks good now, thanks!

@ryelle ryelle merged commit 0754ae0 into WordPress:production Nov 23, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.