Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the incomplete data basics repo to reflect the GB handbook how-to guide #227

Closed
wants to merge 1 commit into from

Conversation

dgwyer
Copy link
Contributor

@dgwyer dgwyer commented Aug 26, 2022

The data basics app on this repo was incomplete so I went through the handbook guide from start to finish and created the app from scratch.

I've also updated the how to guide via a separate PR: WordPress/gutenberg#43633

@adamziel
Copy link
Contributor

adamziel commented Aug 26, 2022

This. Is. Awesome! ❤️ It would be great to lint it to make the checks pass. I confirmed this compiles and looks good at the first glance. I'd like to test it in the browser after the linting just to be triple sure the tutorial gave all the right directions.🤞

@adamziel
Copy link
Contributor

adamziel commented Jan 23, 2023

@dgwyer to lint the code examples I had to:

  1. Install the dependencies with yarn --ignore-engine install (npm install didn't work for me)
  2. Manually install the eslint plugin like yarn --ignore-engines add @wordpress/eslint-plugin@latest (cc @ryanwelcher )
  3. Run npm run format:js

I pushed the changes generated in step 3 to #235 in 3e0acb7

Note the CI still fails – I think it's broken for the entire repo at the moment and it's okay to ignore it for this particular PR.

I could merge #235 with you as the author, or you could add linting to this PR (#227) – whichever you prefer.

@adamziel
Copy link
Contributor

adamziel commented Feb 8, 2023

@ryanwelcher just merged #235 which includes this plus the linting changes

@adamziel adamziel closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants