Fix intermittent RichText e2e test failure (#20457)

WordPress · Mar 16, 2020 · 844b932 · 844b932
1 parent c8c6fa1
commit 844b932
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 58 deletions.
diff --git a/packages/components/src/slot-fill/bubbles-virtually/slot.js b/packages/components/src/slot-fill/bubbles-virtually/slot.js
@@ -1,12 +1,7 @@
 /**
  * WordPress dependencies
  */
-import {
-	useEffect,
-	useRef,
-	useLayoutEffect,
-	useContext,
-} from '@wordpress/element';
+import { useRef, useLayoutEffect, useContext } from '@wordpress/element';
 import isShallowEqual from '@wordpress/is-shallow-equal';
 
 /**
@@ -25,7 +20,7 @@ export default function Slot( {
 	const ref = useRef();
 	const slot = useSlot( name );
 
-	useEffect( () => {
+	useLayoutEffect( () => {
 		registry.registerSlot( name, ref, fillProps );
 		return () => {
 			registry.unregisterSlot( name, ref );

diff --git a/packages/components/src/slot-fill/stories/index.js b/packages/components/src/slot-fill/stories/index.js
@@ -13,7 +13,13 @@ import { createContext, useContext } from '@wordpress/element';
  */
 import { Slot, Fill, Provider } from '../';
 
-export default { title: 'Components/SlotFill', component: Slot };
+export default {
+	title: 'Components/SlotFill',
+	component: Slot,
+	parameters: {
+		storyshots: { disable: true },
+	},
+};
 
 export const _default = () => {
 	return (

diff --git a/storybook/test/__snapshots__/index.js.snap b/storybook/test/__snapshots__/index.js.snap
@@ -4851,56 +4851,6 @@ exports[`Storyshots Components/ScrollLock Default 1`] = `
 </div>
 `;
 
-exports[`Storyshots Components/SlotFill Default 1`] = `
-Array [
-  <h2>
-    Profile
-  </h2>,
-  <p>
-    Name: 
-    <span />
-  </p>,
-  <p>
-    Age: 
-    <span />
-  </p>,
-]
-`;
-
-exports[`Storyshots Components/SlotFill With Context 1`] = `
-Array [
-  <h2>
-    Profile
-  </h2>,
-  <p>
-    Name: 
-    <span />
-  </p>,
-  <p>
-    Age: 
-    <span />
-  </p>,
-]
-`;
-
-exports[`Storyshots Components/SlotFill With Fill Props 1`] = `
-Array [
-  <h2>
-    Profile
-  </h2>,
-  <p>
-    Name:
-     
-    <span />
-  </p>,
-  <p>
-    Age:
-     
-    <span />
-  </p>,
-]
-`;
-
 exports[`Storyshots Components/Snackbar Default 1`] = `
 <div
   className="components-snackbar"