From b605256162f21ba68260cbb5022d27a17f587b87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Szab=C3=B3?= Date: Fri, 16 Jul 2021 13:15:36 +0200 Subject: [PATCH] Navigation component: Fix item handling onClick twice (#33286) --- packages/components/src/navigation/item/index.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/components/src/navigation/item/index.js b/packages/components/src/navigation/item/index.js index 625a5f3cb7265..6996cb6fce272 100644 --- a/packages/components/src/navigation/item/index.js +++ b/packages/components/src/navigation/item/index.js @@ -63,14 +63,15 @@ export default function NavigationItem( props ) { onClick( event ); }; const icon = isRTL() ? chevronLeft : chevronRight; - const baseProps = isText + const baseProps = children ? props : { ...props, onClick: undefined }; + const itemProps = isText ? restProps : { as: Button, href, onClick: onItemClick, ...restProps }; return ( - + { children || ( - +