From b86cbd28668504013decf92af27fcd24aef32cf9 Mon Sep 17 00:00:00 2001
From: ntsekouras <ntsekouras@outlook.com>
Date: Thu, 4 Jan 2024 10:45:42 +0200
Subject: [PATCH] display `sync status` field

---
 packages/dataviews/src/view-grid.js               |  3 +--
 packages/dataviews/src/view-list.js               |  1 -
 packages/dataviews/src/view-table.js              |  1 -
 .../page-patterns/dataviews-patterns.js           | 15 ++++++++++++---
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/packages/dataviews/src/view-grid.js b/packages/dataviews/src/view-grid.js
index ca5d2a9f9a503..5ac4d1d42d573 100644
--- a/packages/dataviews/src/view-grid.js
+++ b/packages/dataviews/src/view-grid.js
@@ -30,7 +30,6 @@ export default function ViewGrid( {
 	);
 	const visibleFields = fields.filter(
 		( field ) =>
-			!! field.render &&
 			! view.hiddenFields.includes( field.id ) &&
 			! [ view.layout.mediaField, view.layout.primaryField ].includes(
 				field.id
@@ -88,7 +87,7 @@ export default function ViewGrid( {
 										{ field.header }
 									</div>
 									<div className="dataviews-view-grid__field-value">
-										{ field.render( { item } ) }
+										{ renderedValue }
 									</div>
 								</VStack>
 							);
diff --git a/packages/dataviews/src/view-list.js b/packages/dataviews/src/view-list.js
index e718d9706c5a7..ab544e0eec9c2 100644
--- a/packages/dataviews/src/view-list.js
+++ b/packages/dataviews/src/view-list.js
@@ -32,7 +32,6 @@ export default function ViewList( {
 	);
 	const visibleFields = fields.filter(
 		( field ) =>
-			!! field.render &&
 			! view.hiddenFields.includes( field.id ) &&
 			! [ view.layout.primaryField, view.layout.mediaField ].includes(
 				field.id
diff --git a/packages/dataviews/src/view-table.js b/packages/dataviews/src/view-table.js
index 2dc1ae5becaa0..5bfcba5def4aa 100644
--- a/packages/dataviews/src/view-table.js
+++ b/packages/dataviews/src/view-table.js
@@ -300,7 +300,6 @@ function ViewTable( {
 } ) {
 	const visibleFields = fields.filter(
 		( field ) =>
-			!! field.render &&
 			! view.hiddenFields.includes( field.id ) &&
 			! [ view.layout.mediaField, view.layout.primaryField ].includes(
 				field.id
diff --git a/packages/edit-site/src/components/page-patterns/dataviews-patterns.js b/packages/edit-site/src/components/page-patterns/dataviews-patterns.js
index d888ea0646adf..c8ae4362297b2 100644
--- a/packages/edit-site/src/components/page-patterns/dataviews-patterns.js
+++ b/packages/edit-site/src/components/page-patterns/dataviews-patterns.js
@@ -78,7 +78,7 @@ const DEFAULT_VIEW = {
 	search: '',
 	page: 1,
 	perPage: 20,
-	hiddenFields: [],
+	hiddenFields: [ 'sync-status' ],
 	layout: {
 		...defaultConfigPerViewType[ LAYOUT_GRID ],
 	},
@@ -260,13 +260,22 @@ export default function DataviewsPatterns() {
 			_fields.push( {
 				header: __( 'Sync Status' ),
 				id: 'sync-status',
+				render: ( { item } ) => {
+					// User patterns can have their sync statuses checked directly.
+					// Non-user patterns are all unsynced for the time being.
+					const [ , notSyncedStatus ] = SYNC_FILTERS;
+					return ! item.syncStatus
+						? notSyncedStatus.label
+						: SYNC_FILTERS.find(
+								( { value } ) => value === item.syncStatus
+						  )?.label;
+				},
 				type: ENUMERATION_TYPE,
 				elements: SYNC_FILTERS,
 				filterBy: {
 					operators: [ OPERATOR_IN ],
 				},
 				enableSorting: false,
-				enableHiding: false,
 			} );
 		}
 		return _fields;
@@ -348,7 +357,7 @@ export default function DataviewsPatterns() {
 					view={ view }
 					onChangeView={ onChangeView }
 					deferredRendering={ true }
-					supportedLayouts={ [ LAYOUT_GRID, 'table' ] }
+					supportedLayouts={ [ LAYOUT_GRID ] }
 				/>
 			</Page>
 		</ExperimentalBlockEditorProvider>