New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screen Options equivalent #10210

Closed
mtias opened this Issue Sep 27, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@mtias
Contributor

mtias commented Sep 27, 2018

Surfacing this one back up as a compatibility and enhancement task. This would be the best way to provide access for custom fields given we are lacking a proper API support for them. This is meant to be a quick implementation using our core APIs: plugin menu, and modal.

screen

The options modal would combine current screen options, the tips, and the publish flow setting. It would absorb some items from the main toolbar, so that it'd end up looking like this:

menu

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 3, 2018

Member

Once this lands, we should make sure to address #3228 (even if it's just to close the issue because Custom Fields have returned).

Member

danielbachhuber commented Oct 3, 2018

Once this lands, we should make sure to address #3228 (even if it's just to close the issue because Custom Fields have returned).

@bkjproductions

This comment has been minimized.

Show comment
Hide comment
@bkjproductions

bkjproductions Oct 18, 2018

I would like to understand this better. Would there be a list of Custom Fields (key/value for each) in this Options modal?
Or is the purpose of the Options modal simply to show a checkbox/button to then allow another section of the interface to show the Custom Fields (key/value for each) at the bottom of the page like it does in the Classic Editor?

bkjproductions commented Oct 18, 2018

I would like to understand this better. Would there be a list of Custom Fields (key/value for each) in this Options modal?
Or is the purpose of the Options modal simply to show a checkbox/button to then allow another section of the interface to show the Custom Fields (key/value for each) at the bottom of the page like it does in the Classic Editor?

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Oct 18, 2018

Contributor

Or is the purpose of the Options modal simply to show a checkbox/button to then allow another section of the interface to show the Custom Fields (key/value for each) at the bottom of the page like it does in the Classic Editor?

More the second point but this is tracked in #3228

Contributor

youknowriad commented Oct 18, 2018

Or is the purpose of the Options modal simply to show a checkbox/button to then allow another section of the interface to show the Custom Fields (key/value for each) at the bottom of the page like it does in the Classic Editor?

More the second point but this is tracked in #3228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment