New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options modal doesn't fit in mobile viewport #10894

Closed
nosolosw opened this Issue Oct 22, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@nosolosw
Member

nosolosw commented Oct 22, 2018

When on a mobile viewport this is how the options modal (editor bar > general settings > options) looks like - note how the close button at the top right is out of the viewport:

options-panel-mobile

@nosolosw

This comment has been minimized.

Member

nosolosw commented Oct 22, 2018

@karmatosed

This comment has been minimized.

Member

karmatosed commented Oct 22, 2018

Is it possible to make it full screen with the close button showing like this:

options

This is based on the sidebar pattern we have for now.

jasmussen added a commit that referenced this issue Oct 23, 2018

Make options modal mobile friendly.
This PR makes the options modal fit on mobile. Fixes #10894.

jasmussen added a commit that referenced this issue Oct 23, 2018

Make options modal mobile friendly. (#10944)
This PR makes the options modal fit on mobile. Fixes #10894.

antpb added a commit to antpb/gutenberg that referenced this issue Oct 26, 2018

Make options modal mobile friendly. (WordPress#10944)
This PR makes the options modal fit on mobile. Fixes WordPress#10894.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment