Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot make changes to image details with the pencil icon in the classic block unless the same edit is applied twice #11433

Closed
turtlepod opened this issue Nov 2, 2018 · 14 comments
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended

Comments

@turtlepod
Copy link

turtlepod commented Nov 2, 2018

Describe the bug
Image In Classic Editor Block is Broken (Gutenberg Version 4.1.1/WordPress 4.9.8)

  • Inserting image always adding it to first in editor
  • editing not working.

To Reproduce
Steps to reproduce the behavior:

  1. Create classic editor block
  2. Add image in content and edit

Video : https://drive.google.com/file/d/1AKG4lm8Otq6uBGJhPgeIbF1QvyAUMARU/view?usp=sharing

Expected behavior
Not broken

Screenshots
Video: https://drive.google.com/file/d/1AKG4lm8Otq6uBGJhPgeIbF1QvyAUMARU/view?usp=sharing

Desktop (please complete the following information):

  • OS: win10
  • Browser chrome 70
@designsimply designsimply added [Feature] Media Anything that impacts the experience of managing media Needs Testing Needs further testing to be confirmed. [Block] Classic Affects the Classic Editor Block labels Nov 2, 2018
@jesscga
Copy link

jesscga commented Nov 2, 2018

I was able to recreate this issue.

I added a thumbnail (150x150) image to a Classic block.

After adding, I was able to change alignment, but not the image size. I clicked the edit button, changed the image size to 800x800, and went back to the block. The image was still a thumbnail and the HTML view showed the original 150x150 size.

Screencast: http://cld.wthms.co/YRTMA2

OS: macOC 10.13.6 High Sierra
Browser: Chrome Version 69.0.3497.100
WordPress 4.9.8
Gutenberg 4.1.1

@designsimply
Copy link
Member

Tested and confirmed using WordPress 4.9.8 and Gutenberg 4.2.0-rc.1 with Firefox 63.0 on macOS 10.13.6, however, I found in my testing that I could make changes to images in the classic block if I made changes twice in a row. Odd! (1m8s)

Thank you for testing and for including a video!

@designsimply designsimply added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Nov 2, 2018
@designsimply
Copy link
Member

Aha! @jesscgs I didn't see your reply before I posted mine. 🙂

@designsimply
Copy link
Member

Note: the problem where an image is always added at the top when using the "Insert Media" button in the classic block is being tracked at #10509.

@La-Geek
Copy link

La-Geek commented Nov 4, 2018

The first issue (image that should be below, but is on top after adding) was described in #10509
but this ticket was hastily closed (why one day later, after the issue has been confirmed here a second time?)

The second issue (resizing image):
Confirmed (I could reproduce it with Gutenberg 4.2.0.-rc.1), does work only after the second time, you have to resize a second time, then it works.

@arunsathiya
Copy link
Contributor

I came here to report the behaviour with image addition at the top, but glad that it's been tracked here #10509.

but not the image size. I clicked the edit button, changed the image size to 800x800, and went back to the block. The image was still a thumbnail and the HTML view showed the original 150x150 size.

I was able to reproduce this as well. My understanding is that, trying to Preview the image size changes and then publishing/updating the post/page reflects the changes. Trying to publish/update without previewing doesn't reflect the changes - or in this case, one will need to update the image size twice to see the changes.

@mtias
Copy link
Member

mtias commented Nov 21, 2018

Closing in favor of #10509.

@mtias mtias closed this as completed Nov 21, 2018
@turtlepod
Copy link
Author

@mtias There's 2 bug in this issue:

  1. inserting image
  2. editing the image (change the image size, etc)

you close this for #10509
Have you create a new issue for # 2?

@turtlepod
Copy link
Author

Nevermind, I create a new issue. Feel free to close if duplicate.
Thanks.

@designsimply
Copy link
Member

Re-tested and confirmed using WordPress 4.9.8 and Gutenberg53e4c40bd (latest master) with Firefox 63.0.1 on macOS 10.13.6 that I cannot make change to an image in the classic block using the pencil icon in the image toolbar unless I make the same adjustment twice. (1m39s)

untitled

@designsimply designsimply reopened this Nov 21, 2018
@designsimply designsimply changed the title Image In Classic Editor Block is Broken Cannot make changes to image details with the pencil icon in the classic block unless the same edit is applied twice Nov 21, 2018
@kristarella
Copy link

I was able to replicate with Gutenberg 4.6.1.

I found that changing the image size of an image added in another editor was inconsistent, until the post was saved in Gutenberg, and then the image size was able to be changed consistently.

Here is my test recording (motorbikes were after post save, see second test in recording with pug to see inconsistency):
gute-classic-edit-image-atomic

@JenniV
Copy link

JenniV commented Dec 7, 2018

I am having this issue as well. I need to change the link twice for it to appear correctly and it's SUPER ANNYOING. Also, every time I change a link the page moves all the way back up to the top so I have to scroll all the way down to continue working. No biggie on a small post, but a long one it's taking me forever. How can I fix this or just turn this new update off.

@azaozz
Copy link
Contributor

azaozz commented Jan 23, 2019

Opened https://core.trac.wordpress.org/ticket/46085 to track this as it's a bug in the wpeditimage WP plugin for TinyMCE. Probably going to be fixed in WP 5.1.

@azaozz
Copy link
Contributor

azaozz commented Jan 23, 2019

Lets move any further discussion/bug reports there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

9 participants