Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3.0] CJK (multi-byte character) input issues using the List, Quote, Pullquote block with Firefox and Chrome #11795

Closed
inc2734 opened this issue Nov 13, 2018 · 25 comments

Comments

@inc2734
Copy link
Contributor

inc2734 commented Nov 13, 2018

Describe the bug
When Japanese is entered in the list block, conversion is decided automatically.
I also reproduced custom blocks set to multiline="li".

To Reproduce
Steps to reproduce the behavior:

  1. Insert list block
  2. Enter multi-byte characters
  3. See error

Screenshots

s

on https://wordpress.org/gutenberg/

Desktop (please complete the following information):

  • OS: macOS High Sierra
  • Browser Chrome
  • Version 70.0.3538.77

It also reproduced in Firefox, but it worked correctly in Safari.

Additional context
I use Gutenberg v4.3.
This problem does not occur in v4.2.

@shinyabw
Copy link
Contributor

shinyabw commented Nov 13, 2018

I tested with WordPress 4.9.8 and Gutenberg 4.3.0 and can confirm that Japanese text (double-byte character) is not usable (cannot type properly) in the list block. I also found the same issue exists with the quote and pullquote blocks.

@lqdjp
Copy link

lqdjp commented Nov 13, 2018

I also found the same issue in the cover and button block.

@mongonta0716
Copy link

mongonta0716 commented Nov 13, 2018

I also found the same issue.
Problems also occur in Google Chrome(70.0.3538.102) on Windows10 Pro 64bit(build 17134.345).
It also reproduces in Firefox(63.0.1).

It worked correctry in Microsoft Edge(42.17134.1.0).

@shinyabw
Copy link
Contributor

shinyabw commented Nov 13, 2018

@mongonta0716 Thank you. I tested further. I am using Mac OS 10.13.6. The issue exsists with Firefox 63.0.1 and Chrome 70.0.3538.102 (Official Build), but it worked fine on Safari 12.0.1.

@lqdjp I could not confirm the issue is the cover and button blocks.

@torounit
Copy link
Member

torounit commented Nov 13, 2018

Using <RichText multiline> will cause this problem.

@shinyabw
Copy link
Contributor

shinyabw commented Nov 13, 2018

@lqdjp I wonder if you are testing this issue on WordPress 5.0-beta4-43896.

@lqdjp
Copy link

lqdjp commented Nov 14, 2018

@shinyabw Yes, I tested with WordPress 5.0-beta4-43896.

@inc2734 inc2734 changed the title When Japanese is entered in the list block, conversion is decided automatically [4.3.0] CJK (double-byte character) input issues using the List, Quote, Pullquote block with Firefox and Chrome Nov 14, 2018
@inc2734 inc2734 changed the title [4.3.0] CJK (double-byte character) input issues using the List, Quote, Pullquote block with Firefox and Chrome [4.3.0] CJK (multi-byte character) input issues using the List, Quote, Pullquote block with Firefox and Chrome Nov 14, 2018
@waviaei
Copy link
Contributor

waviaei commented Nov 15, 2018

Firefox console is given me this error. Not quire sure if it is related, but this is the only error message I get. It is linked to this document https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors

ソースマップエラー: TypeError: NetworkError when attempting to fetch resource.
リソース URL: moz-extension://20e5fbb1-ec98-5141-a675-4a657c2fcc84/node_modules/webextension-polyfill/dist/browser-polyfill.js
ソースマップ URL: browser-polyfill.js.map[詳細]

Desktop (please complete the following information):

  • OS: macOS High Sierra
  • Browser Firefox
  • Version 63.0.1

I use 5.0-beta4-43896.
Only plugin activated is the Beta Tester.

@ellatrix
Copy link
Member

ellatrix commented Nov 15, 2018

Thanks for the report and I'm sorry for the problems you're having! I will need some more information to be able to fix the problem. It's strange that this only happens in the list and quote blocks.

  • Is e.g. the paragraph entirely fine? No input issues at all?
  • How do I reproduce the issue precisely? I know nothing about Japanese, so it's hard for me to test. I managed to install Japanese keyboard on my Mac, and I have three new options: Romaji, Hiragana and Katakana. I'm guessing the problem lies with both Hiragana and Katakana. When I try to input characters in e.g. the list block, only latin characters appear. Is this the problem? This seems to be a bit different fro the GIF you shared.

As mech information as possible would be really appreciated!

@ellatrix
Copy link
Member

ellatrix commented Nov 15, 2018

with Firefox and Chrome

Can you confirm this works properly in all other browsers?

@ellatrix ellatrix self-assigned this Nov 15, 2018
@inc2734
Copy link
Contributor Author

inc2734 commented Nov 15, 2018

Is e.g. the paragraph entirely fine? No input issues at all?

Yes, there is nothing wrong with the paragraph block.

Can you confirm this works properly in all other browsers?

I have only Mac, so IE, Edge can not be confirmed. Sorry.
It does not seem to be a problem with Mac's Safari.

@ellatrix
Copy link
Member

ellatrix commented Nov 15, 2018

Could you elaborate more on what is supposed to happen versus what actually happens? I don't know enough about Japanese to understand the problem fully. Thanks!

@ellatrix
Copy link
Member

ellatrix commented Nov 15, 2018

Also, was this a problem before 4.3, or did this only happen after you updated to 4.3?

@torounit
Copy link
Member

torounit commented Nov 15, 2018

@lqdjp after 4.3. not happen this problem 4.3.

@inc2734
Copy link
Contributor Author

inc2734 commented Nov 15, 2018

I have three new options: Romaji, Hiragana and Katakana. I'm guessing the problem lies with both Hiragana and Katakana.

I may also be wrong because I am not familiar with the keyboard. I use Romaji mode. I did not know how to use Hiragana mode and Katakana mode, but I think that problems will probably occur even in those modes.

When I try to input characters in e.g. the list block, only latin characters appear. Is this the problem? This seems to be a bit different fro the GIF you shared.

To enter Japanese, press the full-width / half-width switch button and enter romaji.

For example, I would like to enter "にほん" (nihonn).

  1. Click the full-width / half-width switch button
  2. I type "nihonn"
  3. Click the conversion button

But, Gutenberg v4.3,

  1. Click the full-width / half-width switch button
  2. I type "ni" (に)

At this stage the conversion is forcibly finalized.

@inc2734
Copy link
Contributor Author

inc2734 commented Nov 15, 2018

There was a problem also in the paragraph block !
The same problem is placed in strong, italic, and link in the paragraph block.

@torounit
Copy link
Member

torounit commented Nov 15, 2018

@mtias mtias removed this from the WordPress 5.0 milestone Nov 15, 2018
@mtias mtias added this to the WordPress 5.0 RC milestone Nov 15, 2018
@ellatrix
Copy link
Member

ellatrix commented Nov 15, 2018

I think this in fixed by #11908 as well. Could someone confirm?

@mongonta0716
Copy link

mongonta0716 commented Nov 15, 2018

I think this in fixed by #11908 as well. Could someone confirm?

@iseulde I can check it if you have a plugin zip file. However, the environment is Windows 10 only.

@waviaei
Copy link
Contributor

waviaei commented Nov 15, 2018

@iseulde Yes, I can confirm for fixed for Mojave. Checked in Chrome, Firefox and Safari in same way as written in #11908 (comment)

@torounit
Copy link
Member

torounit commented Nov 15, 2018

@iseulde Works well on Chrome for Mojave.

@mongonta0716
Copy link

mongonta0716 commented Nov 15, 2018

@iseulde I updated to version 4.4.0 and confirmed it.

Environment
OS:Windows 10 Pro 64bit
Browsers:
Google Chrome
Firefox
Microsoft Edge

@inc2734
Copy link
Contributor Author

inc2734 commented Nov 16, 2018

It worked with Gutenberg v4.4. Thank you very much !!

@lqdjp
Copy link

lqdjp commented Nov 16, 2018

Works well on Chrome for High Sierra.

@ellatrix
Copy link
Member

ellatrix commented Nov 16, 2018

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants