New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockPostSaving not working as expected #11809

tihomirselak opened this Issue Nov 13, 2018 · 2 comments


None yet
5 participants
Copy link

tihomirselak commented Nov 13, 2018

Describe the bug
when you dispatch lockPostSaving action on data store'core/editor').lockPostSaving('lockName');
and when check with'core/editor').lockPostSaving('lockName');
it returns true but update button only looks disabled, you can still click on it and it saves normally

To Reproduce
Steps to reproduce the behavior:

  1. dispatch action command ''core/editor').lockPostSaving('lockName');'
  2. Click on 'Update'

Expected behavior
Update button should not do any action,

Desktop (please complete the following information):

  • OS: Mojave
  • Browser Chrome
  • Version 70

Additional context

  • Gutenberg 4.3

This comment has been minimized.

Copy link

swissspidy commented Nov 13, 2018

Looking at it indeed seems like this will only set aria-disabled to true but not affect the onClick handlers.


This comment has been minimized.

Copy link

ocean90 commented Nov 13, 2018

Related PR with a fix: #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment