New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Blocks: Labeling Inconsistency? #12079

Open
holtjohnson opened this Issue Nov 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@holtjohnson

holtjohnson commented Nov 19, 2018

When I hover over a reusable block before I click on it shows the label in the top right corner to be "Reusable Block" as expected. When I'm editing the reusable block and hover over a block inside the reusable block the label in the top right corner shows "Reusable Template" as the parent when I would expect "Reusable Block". I'm a site developer working to understand exactly how Gutenberg is put together and works. When using Gutenberg I've started to use the hover labels in the top right to tell me where I am and is incredibly helpful when working with block nesting (inner blocks). If this is intentional and part of how reusable blocks work could you link me to the documentation? If this is only a labeling mistake, would you mind mending it? It would help with clarity for me during this change of editor.

Thanks for your work!

To Reproduce

  1. Create a post using Gutenberg.
  2. Insert a reusable block.
  3. Hover over the reusable block and observe the label in the top right corner.
  4. Click on the reusable block.
  5. Click on the "edit" button in the top right.
  6. Hover over one of the blocks inside the reusable block and observe the label in the top right corner.

Expected behavior

I was expecting the labels to both use "Reusable Block".

Screenshots

screen shot 2018-11-19 at 14 29 28
screen shot 2018-11-19 at 14 29 41

Desktop

  • Gutenberg: v4.4.0
  • OS: macOS v10.13.5
  • Browser: Firefox
  • Version: 63.0.3
@designsimply

This comment has been minimized.

Contributor

designsimply commented Nov 21, 2018

I tried testing exactly with the steps you provided (maybe too exactly!) and I found that if I create a reusable block, open a new post, add the reusable block, it is still correctly labeled "Reusable Block." I noticed that in your screenshot you've inserted a group of blocks—looks like it's some headings and paragraphs and social media icons—which I think may actually be a template and so it may be labeled correctly. Can you walk me through how to create the exact same reusable block (or group of blocks) that you have in your screenshot? Was that technically created as a template?

@holtjohnson

This comment has been minimized.

holtjohnson commented Nov 26, 2018

Thanks for your quick reply and following what I asked. I followed my steps exactly as well and didn't see what I was getting at. I guess I assumed someone would figure out the finer details from the images. I wasn't expecting someone to follow them exactly, I must have assumed too much.

The social media icons are a custom block. No templates are used or in effect. The exact steps are:

  1. Create a post using Gutenberg.
  2. Add two paragraph blocks and fill them both with "Hello World".
  3. Select both paragraph blocks and add/create a reusable block out of the two selected blocks.
  4. Hover over one of the blocks inside the reusable block and observe the label in the top right corner.
@holtjohnson

This comment has been minimized.

holtjohnson commented Nov 28, 2018

Also I'm seeing the inaccurate label "Reusable Template" when I use the block navigation as well. I see it when I have selected a block within a reusable block and then click the "Block Navigation" button. In this image I've selected a Heading Block inside a reusable block and then clicked the "Block Navigation" button.
screen shot 2018-11-28 at 10 56 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment