Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing editor mode switching (Visual/Code Editor) #12374

Open
webmandesign opened this issue Nov 27, 2018 · 6 comments

Comments

@webmandesign
Copy link
Contributor

commented Nov 27, 2018

Description

Options to switch between "Visual Editor" and "Code Editor" mode are pretty confusing. They basically work like radio buttons, however, the checkmark icon sets expectation they would work the same way as, for example, the "Top Toolbar" option, which is basically a toggle button (a checkbox).

Expected behavior

Not sure whether "Visual Editor" option is even needed. Could there only be a "Code Editor" option that works like a toggle button?

Video

https://www.dropbox.com/s/aw2x03xjjwja1u3/gutenberg-editor-mode-switching.mp4

Additional context

@swissspidy

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Not sure how well a toggle button would work accessibility-wise. Just so that it won‘t be forgotten.

@webmandesign

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

Yes, accessibility is also my concern.
But I'm coming from presumption that those already included toggle buttons ("Top Toolbar" option, for example) are accessible. So, implementing similar functionality for editor mode switcher shouldn't be a problem(?).

@karmatosed karmatosed added this to the Future: 5.1 milestone Nov 28, 2018

@mapk

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

An additional benefit for keeping them as they are is it helps with terminology. If we eliminate the "Visual editor" choice, people begin to call it all sorts of things.

@Nobiuss

This comment has been minimized.

Copy link

commented Jun 20, 2019

Hi,

I understand the confusions about this because the look is the same and they don't act the same.
Maybe it is best if there would be some kind of a switch for the visual or code editor.
I will add a mockup for this, how it can look.

image (2)

Kind regards,
Kim

@afercia

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

Worth reminding the "More" dropdown is an ARIA menu, and as such can contain exclusively items of type menuitem, menuitemcheckbox, menuitemradio.

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I'm taking another look at how the Code Editor might work as a whole in this other issue:
#17017

Chances are, it will affect this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.