New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote block: the "Large" option on the left in the styles panel does not show a preview #12956

Open
designsimply opened this Issue Dec 17, 2018 · 2 comments

Comments

3 participants
@designsimply
Copy link
Contributor

designsimply commented Dec 17, 2018

Steps to reproduce:

  1. Add a quote block.
  2. Click the icon to "Change block type".
  3. Check to see if the "Large" block style variation shows any preview.

Result: the "Large" block style variation for the quote block doesn't seem to show a preview for the selector—the preview on the right of it shows normally when you click on "Large" though.

screen shot 2018-12-17 at 12 11 18 pm
Tested with WordPress 5.0.1 and Gutenberg 4.7.0 master @ ddac4f3cf using Firefox 63.0.3 on macOS 10.13.6.

/hat tip @andreilupu for the original report in the 4.7 call for testing at https://make.wordpress.org/test/2018/12/12/call-for-testing-gutenberg-4-7/#comment-1140

@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Feb 1, 2019

@laurelfulford noticed this problem recently due to a Twenty Nineteen theme Trac ticket. It's due to the larger amount of margin-top the quote uses. The margin pushes the quote out of view from the smaller preview window.

We need a way for the preview to ignore the margin or maybe force the margins to be less in the preview window.

@Presskopp

This comment has been minimized.

Copy link
Contributor

Presskopp commented Feb 1, 2019

for reference, here the trac ticket:
https://core.trac.wordpress.org/ticket/45385

@mapk mapk moved this from To Do to Tighten Up in Phase 2 Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment