Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RSS Block #13498

Open
gziolo opened this Issue Jan 25, 2019 · 11 comments

Comments

Projects
5 participants
@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

#7966 which contains the first iteration of RSS block had landed. There was agreement that we can tackle follow-up tasks separately to make the process smoother. This issue list all the feedback which still needs to be addressed:

  1. Set min number of words. (PR: #13502)

screen shot 2019-01-24 at 14 06 42

  1. Let's change text from "Max length of the excerpt" to "Max number of words in excerpt".
    (PR: #13501)

screen shot 2019-01-24 at 14 08 15

  1. When there is an error we still display all controls (it's related to the aforementioned change to the way ServerSideRender component works:

screen shot 2019-01-24 at 14 09 36

  1. Let's fix the error message. I don't think many will understand "WP HTTP Error: cURL ..." Can we just say, "Could not resolve host: xxxx"?

  2. Let's review all translations used:

jul-15-2018 13-02-58

bildschirmfoto 2018-07-15 um 13 15 53

PHP file: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/rss/index.php

@gziolo gziolo modified the milestone: 5.0 (Gutenberg) Jan 25, 2019

@gziolo gziolo added this to To Do in Phase 2 via automation Jan 25, 2019

@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Jan 25, 2019

@Soean do you plan to work on any of the listed items? I can help with tweaking ServerSideRender component.

@Soean

This comment has been minimized.

Copy link
Member

Soean commented Jan 25, 2019

Yes, I'm gonna work them off.
What would be a good minimum? 1, 5, 10?

@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Jan 25, 2019

What would be a good minimum? 1, 5, 10?

10 seems to be reasonable, let's discuss in PR.

@michelleweber

This comment has been minimized.

Copy link

michelleweber commented Jan 25, 2019

Max length text looks good.

For the error, I think it's good to lose the first bit. Is there anything else we can add there? It's always good to try and give people a path to resolution. If I get this error, what do I do next?

@gziolo gziolo added this to the WordPress 5.x milestone Jan 25, 2019

@melchoyce

This comment has been minimized.

Copy link
Contributor

melchoyce commented Jan 25, 2019

Additionally, are there any other errors that can possibly appear?

@Soean

This comment has been minimized.

Copy link
Member

Soean commented Jan 25, 2019

Errors:

  1. No RSS feed on the site:
    RSS Error: A feed could not be found at https://drupal.org/. A feed with an invalid mime type may fall victim to this error, or SimplePie was unable to auto-discover it.. Use force_feed() if you are certain this URL is a real feed.

  2. No valid feed:
    RSS Error: This XML document is invalid, likely due to invalid characters. XML error: not well-formed (invalid token) at line 42, column 299 (Example: https://typo3.org/)

  3. Non valid domain:
    RSS Error: WP HTTP Error: cURL error 6: Could not resolve host: xxx

  4. Timeout:
    RSS Error: WP HTTP Error: cURL error 28: Operation timed out after 10069 milliseconds with 0 bytes received

  5. If you work offline
    RSS Error: WP HTTP Error: cURL error 6: Could not resolve host: wordpress.org

  6. Empty feed:
    An error has occurred, which probably means the feed is down. Try again later.

1. and 2. are messages from the library SimplePie which we use
3. - 5. are WordPress HTTP request errors
6. Can we change inside the block.

@melchoyce

This comment has been minimized.

Copy link
Contributor

melchoyce commented Jan 25, 2019

Thanks @Soean!

@Soean

This comment has been minimized.

Copy link
Member

Soean commented Jan 25, 2019

I updated my answer. Maybe there are more errors I haven't found yet.

I think we should remove the RSS Error: in front of the errors. The styled message should be clear enough and there is already a WP HTTP Error: in front of the HTTP request errors.

@Soean Soean moved this from To Do to In progress in Phase 2 Jan 25, 2019

@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Jan 28, 2019

@youknowriad found an issue which requests the changes to the ServerSideRender component which align with what is necessary for RSS block, see #7346.

@desrosj

This comment has been minimized.

Copy link
Contributor

desrosj commented Feb 5, 2019

I came here after testing the 5.0RC1 and came here to suggest less technical error messages be displayed.

It would also be nice if you could just include an RSS block, and the associated feed title automatically displays. Having to add a heading block and an RSS block and keeping them together could be cumbersome.

@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Feb 5, 2019

I came here after testing the 5.0RC1 and came here to suggest less technical error messages be displayed.

Yes, this is listed already. I found it really unfriendly for users from the first time I saw it 👍

@noisysocks noisysocks moved this from In progress to Widgets in Phase 2 Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.