Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use text link instead of auto embed. #15102

Open
paaljoachim opened this issue Apr 22, 2019 · 3 comments · May be fixed by #17413

Comments

@paaljoachim
Copy link

commented Apr 22, 2019

Is your feature request related to a problem? Please describe.
Adding links. If an link goes to another WordPress site we will see an auto embed such as this:

Screen Shot 2019-04-22 at 11 12 35

A mix of auto embeds and text links.

Screen Shot 2019-04-22 at 11 22 24

Describe the solution you'd like
I would like the option to include an auto embed OR a text link. As some links above are automatically embedded showing an article preview while other links just show a text link.

Describe alternatives you've considered
I added the following code from my tutorial here:
https://easywebdesigntutorials.com/adjusting-the-auto-embeds-of-wordpress-site-links-on-your-site/

By adding code from the above tutorial it forces the link dialog box to open for the links that were auto embedded. I can then select to convert the auto embeds to regular text links. One should not need to add the code to turn off auto embeds.
Screen Shot 2019-04-22 at 11 39 36

@paaljoachim paaljoachim changed the title Add option to link embed to use or not use auto embed Option to use text link instead of auto embed. Apr 22, 2019

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Thanks for opening the issue, this was discussed during the triage session today https://wordpress.slack.com/archives/C02QB2JS7/p1555939888308300

Based on these discussions, we propose to add a block transform to transform embed blocks to paragraph blocks but we should create <a> tags as content of the paragraph blocks to avoid the auto-embed to trigger in the frontend.

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Hello Jorge. @jorgefilipecosta
Would this issue be something that you might be able to tackle?

Adding a link should have consistency. When a link is suddenly embedded and looks different then other links then that can create frustration.

When a link wants to embed itself so that it shows different then a standard text link then the default placeholder box should show up asking if one wants to embed the link.

I will also add in some design folks.
@mapk @kjellr

@kjellr

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

The paste-a-link-to-embed functionality here is the same as other embed blocks, so I think the block transform to paragraph makes sense as a first step here.

@desaiuditd desaiuditd referenced a pull request that will close this issue Sep 12, 2019
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.