Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "saved" notification disappear on edit #15132

Closed
draganescu opened this issue Apr 23, 2019 · 4 comments · Fixed by #15594

Comments

@draganescu
Copy link
Contributor

commented Apr 23, 2019

Screenshot 2019-04-23 at 23 00 20

Is your feature request related to a problem? Please describe.
There is an oldish Trac ticket about this but I think it doesn't apply anymore code-wise, but the behaviour still exists in Gutenberg.

Briefly when a piece of content is saved, we get this green bar that says: "Post updated.". The bar stays there forever unless you close it with the mouse.

Describe the solution you'd like
The bar should disappear after a while or on first edit.

@karmatosed

This comment has been minimized.

Copy link
Member

commented May 7, 2019

I am removing the 'User Experience (UX)' label as part of a label cleanup. It's not being used anymore consistently so let's try and keep to 'needs design' and 'needs design feedback'. If we find a need for another label we can consider it but having those 2 should cover this.

@afercia

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Discussed during today's accessibility bug scrub. Not sure if this is still relevant, as we've heard there are ongoing explorations with the "snackbars".

In any case, there are two concerns:

  • Content (in this case important notices) that disappears on a time based interval violates a specific WCAG guideline. Rationale: some users may need more time to get to the content. Intervals should be adjustable.
  • Potential focus loss: if the "View Post" link is focused and the notice gets removed from the DOM, there's a focus loss. This should be avoided at all costs.
@draganescu

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

This will be solved by #15594 by having any notification disappear in 10s. It is not exactly as described here but it remains to be seen if this behaviour will be needed.

@draganescu draganescu closed this May 24, 2019

@afercia

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Thanks for pointing it out. Worth noting the accessibility of the so called "snackbars" is to evaluate yet, as there are serious concerns there. (see the non-adjustable timeout to start with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.