Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: Column: Add draggable resize control #15659

Open
aduth opened this issue May 15, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@aduth
Copy link
Member

commented May 15, 2019

Previously: #15499

As of #15499, it is possible to resize a Column block using the "Percentage width" input in the block inspector. We should seek to enhance this by adding optional interactive controls within the rendered display of the block itself.

Implementation specifics:

It should likely be implemented using ResizableBox, and behave similarly to the Media & Text block resizing.

I had originally spent some time on this in #15499, reflected in the following in-progress (including clumsy attempts at math) diff at: https://gist.github.com/aduth/dc2136eb703a3c1dad39b3879f37ac6e

Per @jasmussen's comment at #15499 (comment), this may need to be reconsidered, however. The above diff assumes that each column would display its own resizer, and only when it is selected. From this design recommendation, the resizer may well become either part of the rendered output of the Columns parent block, or as some customization of how it renders InnerBlocks. It may be necessary to enhance InnerBlocks to customize the rendered output of individual blocks in the nested area, similar to what was done for customizing appender behavior with renderAppender introduced in #14241 (e.g. renderBlock).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.