Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover: Allow directly setting a background #16996

Closed
mtias opened this issue Aug 10, 2019 · 5 comments · Fixed by #17041

Comments

@mtias
Copy link
Contributor

commented Aug 10, 2019

The Cover block has evolved quite a bit from its time as just a Cover Image, supporting a lot of interesting configurations (videos, overlays, etc).

It'd be interesting to let users select a solid color if they want to skip setting an image or video from the placeholder step. It could look something like this:

image

When background gradient options are finalized, we should revise the presentation a bit.

Also, once patterns (#16283) are further established, it'd be cool to surface a few predefined defaults here as well to show the variety of end results. It gets tricky with media as it cannot be easily previewed before user uploads content.

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

This tends to push toward the Group block quite a bit. I'm okay with that because the Cover block feels much more opinionated design-wise. Providing background color support is a good evolution. The PR should also include the background color options in the Block Settings sidebar.

@senadir senadir self-assigned this Aug 12, 2019

@senadir senadir referenced this issue Aug 14, 2019
5 of 5 tasks complete
@enriquesanchez

This comment has been minimized.

Copy link

commented Aug 14, 2019

Hey @senadir!

Here are a couple of initial mockups.

A) Similar to the color settings on the block sidebar, but using only one row of colors to keep it short. It includes the options to select a custom color (if one is selected, we can then show the Clear button)

Screen Shot 2019-08-14 at 5 40 50 PM

B) Similar concept but making the last color a color picker button instead.
Screen Shot 2019-08-14 at 5 40 57 PM

Let me know what you think. Which one seems more feasible?

cc @mapk

@senadir

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

you can reference #17041
@enriquesanchez any use for the clear button?

@enriquesanchez

This comment has been minimized.

Copy link

commented Aug 15, 2019

@enriquesanchez any use for the clear button?

Yep, definitively. I was suggesting that if no color has been selected, we don't need to show the Clear button.

@senadir

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

and when selecting a color, the view changes directly and the options will move to the side panel, making the existence of the clear button useless in that view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.