Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Reduce toolbar options for menu item #18318

Closed
karmatosed opened this issue Nov 6, 2019 · 11 comments · Fixed by #19507
Closed

Navigation Block: Reduce toolbar options for menu item #18318

karmatosed opened this issue Nov 6, 2019 · 11 comments · Fixed by #19507

Comments

@karmatosed
Copy link
Member

@karmatosed karmatosed commented Nov 6, 2019

Right now you see a lot of options for menu items that I think could be reduced.

nav-toomuch

I would suggest all 3 are removed.

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Nov 6, 2019

Inline image is useful if you want to add an icon before the text. I'd probably only remove the inline code. (Also this can be extended by plugins.)

@mtias mtias added the [Priority] Low label Nov 7, 2019
@MDWolinski

This comment has been minimized.

Copy link

@MDWolinski MDWolinski commented Dec 10, 2019

Removing any or all of these options reduces the ability of the user to format their inline paragraph text in the wysiwyg environment, unless these options were added to another place on the interface.

To me, we would need to expand this menu to allow additional inline text formatting such as: Underline, Superscript, and Subscript which would match some functionality of the classic editor.

However, should that be baked into core or is this menu able to be added to by Plug-ins where users would have to add a Superscript plugin to add that capability.

@shaunandrews shaunandrews changed the title Reduce toolbar options for menu item Navigation Block: Reduce toolbar options for menu item Dec 10, 2019
@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Dec 18, 2019

A good decision here is then to remove inline code. I am removing feedback and marking this to be moved to a PR.

karmatosed added a commit that referenced this issue Dec 19, 2019
Fixes #18318 by removing reusable blocks.
Navigation block automation moved this from 🗂 To do to ✅ Done Dec 19, 2019
@karmatosed karmatosed reopened this Dec 19, 2019
Navigation block automation moved this from ✅ Done to 🗂 To do Dec 19, 2019
@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Dec 19, 2019

Wrongly closed by issue mis-numbering.

@karmatosed karmatosed closed this Dec 19, 2019
Navigation block automation moved this from 🗂 To do to ✅ Done Dec 19, 2019
@karmatosed karmatosed reopened this Dec 19, 2019
Navigation block automation moved this from ✅ Done to 🗂 To do Dec 19, 2019
@karmatosed karmatosed removed their assignment Dec 27, 2019
WunderBart added a commit to WunderBart/gutenberg that referenced this issue Jan 8, 2020
Navigation block automation moved this from 🗂 To do to ✅ Done Jan 8, 2020
frontdevde added a commit that referenced this issue Jan 8, 2020
@MDWolinski

This comment has been minimized.

Copy link

@MDWolinski MDWolinski commented Jan 8, 2020

I still don't understand the logic for removing Inline Code from the formatting menu.

But even worse, I don't understand why have a drop down menu with only two options on it? You are literally 1 button on the main NavigationLink away from not needing a drop down menu.

@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Jan 8, 2020

@MDWolinski happy to chat about this more, it's closed because the extending work has been done on this now. Inline code I do stand by being not a common case, that said would you be able to give a clear case where you feel this would be used and we can review? As far as allowing additional, if I am understanding there is now the option to extend so that can be done in an awesome plugin.

@MDWolinski

This comment has been minimized.

Copy link

@MDWolinski MDWolinski commented Jan 8, 2020

@karmatosed While I appreciate the goal of making the interface as tight as possible, a WYSIWYG editor has just a handful of inline code formatting options that have valid uses in blogging. While I don't necessarily have blog post examples at hand, you see Inline Code used heavily in comments and Slack.

Code Used in Slack

To regress this functionality, which is already built in, to a plug-in seems like a heavy-handed approach just to add <code> and </code> into the code. (See, I just used it for that sentence.) I'd prefer to reduce the number of plug-ins needed to necessary ones and not have to install a handful just to handle WYSIWYG functionality.

Blogs that deal with technical / development topics may utilize the Inline Code heavily.

To that end, I'd also argue for the inclusion of Sub/Superscript which is beneficial for creating footnotes, etc in long form/educational posts.

@MDWolinski

This comment has been minimized.

Copy link

@MDWolinski MDWolinski commented Jan 8, 2020

Also, while I've not reviewed the code submitted for this issue, at glance it seems to limit the menu to specific items and is not capable of being extended. But I'm not holding a hardline on that.

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Jan 8, 2020

@MDWolinski this issue only applies to rich formatting when writing a label for a menu item, not for rich text in general (like in paragraphs, quotes, etc).

@MDWolinski

This comment has been minimized.

Copy link

@MDWolinski MDWolinski commented Jan 8, 2020

@mtias @karmatosed Doh! I get it now. 🙄 🤦‍♂

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Jan 8, 2020

Hah, no worries! :)

@WunderBart WunderBart self-assigned this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
5 participants
You can’t perform that action at this time.