Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent where we say edit or change #18321

Closed
karmatosed opened this issue Nov 6, 2019 · 2 comments · Fixed by #19505
Closed

Be consistent where we say edit or change #18321

karmatosed opened this issue Nov 6, 2019 · 2 comments · Fixed by #19505

Comments

@karmatosed
Copy link
Member

@karmatosed karmatosed commented Nov 6, 2019

The new link interface says 'change' and we say 'edit' in other places. I suggest we should be consistent about saying just one of these and do it throughout. I don't really mind which but we might want to explore which translates more elegantly.

nav-linkstate

@markarms

This comment has been minimized.

Copy link

@markarms markarms commented Nov 6, 2019

I can't speak to translation here but agree that "Edit" makes sense, and if it is already in use across other areas, then we should go with that.

@mapk mapk removed the Needs Copy Review label Nov 7, 2019
@mapk

This comment has been minimized.

Copy link
Contributor

@mapk mapk commented Nov 7, 2019

I agree that "Edit" should work fine here.

Navigation block automation moved this from 🗂 To do to ✅ Done Jan 8, 2020
@WunderBart WunderBart self-assigned this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
5 participants
You can’t perform that action at this time.