Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only h2 can be confirmed in the heading block style preview #18424

Open
ddryo opened this issue Nov 11, 2019 · 3 comments
Open

Only h2 can be confirmed in the heading block style preview #18424

ddryo opened this issue Nov 11, 2019 · 3 comments

Comments

@ddryo
Copy link
Contributor

@ddryo ddryo commented Nov 11, 2019

Since the level is set to 2 in the “example” setting of the heading block, H3 and H4 cannot be confirmed on the preview screen of the style panel.

example_setting_of_heading

▼ The following gif image is when the style is changed

bug_demo_heading_preview

@ddryo

This comment has been minimized.

Copy link
Contributor Author

@ddryo ddryo commented Dec 6, 2019

The same problem can be seen on the style preview screen of the list block.
Since it is forcibly fixed to the ul tag, the style preview of the ol tag cannot be confirmed.

▼ The following gif image is when the style is changed
bug_demo_list_preview

@ddryo

This comment has been minimized.

Copy link
Contributor Author

@ddryo ddryo commented Dec 6, 2019

Of course, eliminating the example setting solves this problem, but without the example setting, the preview in the block inserter help menu (.block-editor-inserter__menu-help-panel) cannot be displayed.

I think that there is a problem with the processing method that the "preview screen in the help menu of the block inserter" and the "block style preview screen" refer to the same "example".

I think it would be nice to be able to divide the process well between the two types of preview screens, but I'm not mature enough to come up with a concrete good solution.
I'm sorry, can the core team consider it?

@ddryo

This comment has been minimized.

Copy link
Contributor Author

@ddryo ddryo commented Dec 6, 2019

Created a plugin that adds a simple block style to heading and list blocks.

I hope you can use it for verification.

▼ The plugin.
my-guten.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.