Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block adds an empty link for untitled pages #18897

Closed
guicmazeredo opened this issue Dec 3, 2019 · 3 comments · Fixed by #19528
Closed

Navigation Block adds an empty link for untitled pages #18897

guicmazeredo opened this issue Dec 3, 2019 · 3 comments · Fixed by #19528

Comments

@guicmazeredo
Copy link

@guicmazeredo guicmazeredo commented Dec 3, 2019

Describe the bug
When creating a navigation block from all top pages, if there are untitled pages, the links to these pages not added.

To reproduce
Steps to reproduce the behavior:

  1. Make sure you have at least 1 page published with no title.
  2. Add a Navigation Block to a page.
  3. Click on "Create from all top pages"
  4. A menu item is added for the untitled page but it doesn't have a link to the page like the other pages.

Expected behavior
I would expect that the link to the page would be pulled just like it does for pages with titles. I also find that it would be more clear if instead of "Add link" the menu item was named "Untitled" just like it appears for untitled pages.

Screenshots
I recorded this video to show:

https://d.pr/v/kqxxCc

@obenland obenland added this to 🗂 To do in Navigation block via automation Dec 4, 2019
@devdivdev devdivdev mentioned this issue Dec 11, 2019
0 of 6 tasks complete
@WunderBart

This comment has been minimized.

Copy link
Member

@WunderBart WunderBart commented Jan 8, 2020

I would expect that the link to the page would be pulled just like it does for pages with titles.

I can see that the link is actually pulled correctly there:

untitled top level page nav link

Could you confirm, @guicmazeredo?

@WunderBart

This comment has been minimized.

Copy link
Member

@WunderBart WunderBart commented Jan 8, 2020

it would be more clear if instead of "Add link" the menu item was named "Untitled" just like it appears for untitled pages.

Should we use (no title) instead of Untitled as we currently do for posts without titles? I'd also suggest to prepend the post number to (no title) as it's currently done in the Primary Menu:

image

Adding the post number should become possible when the #18641 is in.

@marekhrabe

This comment has been minimized.

Copy link
Contributor

@marekhrabe marekhrabe commented Jan 8, 2020

it sounds reasonable to match (no title) from other places 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
5 participants
You can’t perform that action at this time.