Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The demo templates were not included in the last release zip #19066

Closed
youknowriad opened this issue Dec 11, 2019 · 2 comments · Fixed by #19072
Closed

The demo templates were not included in the last release zip #19066

youknowriad opened this issue Dec 11, 2019 · 2 comments · Fixed by #19072

Comments

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Dec 11, 2019

This file is missing /lib/demo-block-templates/index.html
It's probably related to the build-zip script.
We should consider a 7.1.1 once we fix that.

cc @epiqueras

@aduth

This comment has been minimized.

Copy link
Member

@aduth aduth commented Dec 11, 2019

It's probably related to the build-zip script.

Specifically, the ZIP includes only whitelisted files:

build_files=$(ls build/*/*.{js,css,asset.php} build/block-library/blocks/*.php)
# Generate the plugin zip file.
status "Creating archive... 🎁"
zip -r gutenberg.zip \
gutenberg.php \
lib/*.php \
packages/block-serialization-default-parser/*.php \
post-content.php \
$vendor_scripts \
$build_files \
readme.txt \
changelog.txt \
README.md

If there are new files to be included, a corresponding pattern should be expected in the parameters of this command.

@epiqueras

This comment has been minimized.

Copy link
Contributor

@epiqueras epiqueras commented Dec 11, 2019

Thanks @aduth, I opened a PR: #19072.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.