Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme name in Template Selector #20469

Open
mtias opened this issue Feb 26, 2020 · 9 comments
Open

Theme name in Template Selector #20469

mtias opened this issue Feb 26, 2020 · 9 comments

Comments

@mtias
Copy link
Contributor

@mtias mtias commented Feb 26, 2020

It'd be good to display the current theme name in the template selector of edit-site.

image

@mapk mapk added this to Needs design in Full site editing Mar 3, 2020
@MichaelArestad MichaelArestad moved this from Needs design to In progress in Full site editing Mar 5, 2020
@shaunandrews

This comment has been minimized.

Copy link
Contributor

@shaunandrews shaunandrews commented Mar 6, 2020

At the bare minimum, I could see adding a section to the bottom of the menu to display the theme name...

image

...but I'm not entirely sure what purpose this serves. Maybe we can add a preview on hover, and some other options to view the theme details and view all themes:

Template Menu with Theme

The "Theme details" item probably isn't necessary — selecting the theme name could open the details like we do now in the Themes screen in wp-admin:

image

I'm not sure if we can use that exact modal within the editor, but I could see adapting that UI. We could look to add more template-related information about the theme here as well.

@shaunandrews shaunandrews moved this from In progress to Needs design feedback in Full site editing Mar 6, 2020
@MichaelArestad

This comment has been minimized.

Copy link

@MichaelArestad MichaelArestad commented Mar 6, 2020

It'd be good to display the current theme name in the template selector of edit-site.

@mtias I'm still curious as to why. I'm not sure exactly what purpose this would serve.

@mtias

This comment has been minimized.

Copy link
Contributor Author

@mtias mtias commented Mar 7, 2020

Right now you cannot tell while in edit site view which theme you have enabled. The templates and template parts come from a mixture of site content (user modified) and theme content. It's important to trace where those are coming from.

@MichaelArestad

This comment has been minimized.

Copy link

@MichaelArestad MichaelArestad commented Mar 11, 2020

Right now you cannot tell while in edit site view which theme you have enabled. The templates and template parts come from a mixture of site content (user modified) and theme content. It's important to trace where those are coming from.

@mtias Right. Perhaps we can delineate which templates are coming from the theme and show the theme name in conjunction with the template? Perhaps when previewing the template?

@mtias

This comment has been minimized.

Copy link
Contributor Author

@mtias mtias commented Mar 11, 2020

That's somewhat already in place — all templates come from the theme unless they have the "modified by user" dot as explained here #19269

image

@MichaelArestad

This comment has been minimized.

Copy link

@MichaelArestad MichaelArestad commented Mar 11, 2020

@mtias And templates couldn't be added by other sources like plugins?

@shaunandrews

This comment has been minimized.

Copy link
Contributor

@shaunandrews shaunandrews commented Mar 11, 2020

Building on the work from #20470, here's the latest on the theme info (shown in its :hover state):

image

@mapk

This comment has been minimized.

Copy link
Contributor

@mapk mapk commented Mar 24, 2020

This hover experience from @shaunandrews communicating the theme visually works really well. I noted that if this hover+preview is used here, it would be great to see it used for the templates in this issue: #20476

@johnstonphilip

This comment has been minimized.

Copy link
Contributor

@johnstonphilip johnstonphilip commented Mar 24, 2020

What would show where the theme is, if the template is not part of the theme, but only exists as a wp_template post_type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Full site editing
Needs design feedback
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.