Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a specification that the "wp-block-heading" class has disappeared from the heading block? #21062

Closed
ddryo opened this issue Mar 21, 2020 · 2 comments
Labels
[Block] Heading Affects the Headings Block Needs Testing Needs further testing to be confirmed. [Type] Regression Related to a regression in the latest release

Comments

@ddryo
Copy link
Contributor

ddryo commented Mar 21, 2020

I am trying 5.4-RC3.
One thing I noticed is that the heading block doesn't have "wp-block-heading".

From what I have seen, the structure of the heading block is as follows:
.wp-block[data-type="core/heading"] > h2.rich-text

However, paragraph blocks have a "wp-block-paragraph" class.
.wp-block[data-type="core/paragraph"] > p.rich-text.wp-block-paragraph

(".block-editor-rich-text__editabl" is omitted)

@gziolo gziolo added [Block] Heading Affects the Headings Block [Type] Regression Related to a regression in the latest release Needs Testing Needs further testing to be confirmed. labels Mar 25, 2020
@youknowriad
Copy link
Contributor

That's actually not a regression because the frontend doesn't have this class and we want to match the frontend as closely as possible. The paragraph class has also been recently removed.

Thanks.

@ddryo
Copy link
Contributor Author

ddryo commented Apr 2, 2020

understood! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block Needs Testing Needs further testing to be confirmed. [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants