Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block "File" not accessible in frontend #22908

Closed
00travelgirl00 opened this issue Jun 4, 2020 · 2 comments · Fixed by #28062
Closed

Block "File" not accessible in frontend #22908

00travelgirl00 opened this issue Jun 4, 2020 · 2 comments · Fixed by #28062
Labels
[Block] File Affects the File Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@00travelgirl00
Copy link

Describe the bug
Download Button in File Block is not accessible for screen reader users.

The Download Block shows the link of the file and a button to download. Both are not connected with each other, also the download attribute is missing.

Screen reader users will only hear the "Link [name of the link]" and "Link [Download]". So they are missing out the information which file they are gonna to download.

To reproduce

  1. Create a File block
  2. Use a screenreader and go over the block in the frontend

Expected behavior
you should here "download [name of file]"

Screenshots

Bildschirmfoto 2020-06-04 um 16 48 16

Bildschirmfoto 2020-06-04 um 16 48 30

Desktop (please complete the following information):

  • OS and Voice Over

WordPress 5.4.1
Gutenberg Plugin 8.2.1

**Possible Solution

add an ID to the link of the file and add a Aria Description to the Button with the ID of the file

@enriquesanchez enriquesanchez added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Block] File Affects the File Block labels Jun 4, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 4, 2020
@jeryj jeryj removed their assignment Jun 4, 2020
@gziolo gziolo added Needs Dev Ready for, and needs developer efforts Needs Accessibility Feedback Need input from accessibility and removed Needs Accessibility Feedback Need input from accessibility [Status] In Progress Tracking issues with work in progress labels Jun 19, 2020
@gziolo
Copy link
Member

gziolo commented Jun 19, 2020

@enriquesanchez or @afercia, it sounds like something that should be addressed.

If my assumption is confirmed, it will require deprecation entry in the block definition. We won’t be able to apply such fix back to already published posts but it’s be auto-fixed when saving edited posts.

@enriquesanchez
Copy link
Contributor

Thanks @gziolo!

@jeryj already started a PR and I believe he shared some of the same concerns you mentioned.

@enriquesanchez enriquesanchez added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 11, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
4 participants