Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and Loop Block: Tracking #24762

Closed
20 of 26 tasks
mtias opened this issue Aug 24, 2020 · 9 comments
Closed
20 of 26 tasks

Query and Loop Block: Tracking #24762

mtias opened this issue Aug 24, 2020 · 9 comments
Labels

Comments

@mtias
Copy link
Member

mtias commented Aug 24, 2020

An initial implementation of the Query and Loop blocks is in place. It's missing some next steps around customizing the query, sidebar controls, and particularly pattern integration for editing and handling different displays of post lists.

High

Normal

Needs Decision

  • Explore combining Query and Loop: the current setup is confusing to work with. - There are InnerBlocks limitations and needs more explorations. Maybe the Query should absorb the Loop's Toolbar.
@ntsekouras
Copy link
Contributor

Address missing query functionality. (Expand...)

This might be the proper place to discuss some design decisions about the contents of toolbar and sidebar.

Related PR: #24691, that adds some order support in the Query block.

@ockham
Copy link
Contributor

ockham commented Aug 24, 2020

FYI @david-szabo97

@gziolo
Copy link
Member

gziolo commented Nov 26, 2020

@mtias, should we include more items on the todo list, some of the references to consider:

@mtias
Copy link
Member Author

mtias commented Nov 26, 2020

@gziolo definitely, feel free to add them

@gziolo
Copy link
Member

gziolo commented Nov 26, 2020

I included both of them with priority Normal. In addition, I added to the list the following item:

@aristath created it based on his explorations of Drupal's Views module summarized in #25790.

@mtias
Copy link
Member Author

mtias commented Nov 26, 2020

@gziolo two things, though: "Query Title" is just "Page Title" and not tied to the query but tied to the template resolver. I think it should be added to the Milestone:4 Theme Blocks — #22724 instead

@gziolo
Copy link
Member

gziolo commented Nov 26, 2020

@gziolo two things, though: "Query Title" is just "Page Title" and not tied to the query but tied to the template resolver. I think it should be added to the Milestone:4 Theme Blocks — #22724 instead

That's a good point, I will move.

It triggers two questions

  • whether we should have Page Loop and Page Navigation blocks listed in the inserter (scoped to the template or so to speak global query arguments)
  • whether Page Title block is separate from Post (type) Title

I'm personally still having harder time visualizing how it would work best for users.

@ntsekouras
Copy link
Contributor

ntsekouras commented Nov 27, 2020

@gziolo two things, though: "Query Title" is just "Page Title" and not tied to the query but tied to the template resolver. I think it should be added to the Milestone:4 Theme Blocks — #22724 instead

I also think that Title could be left separate and be handled with PostTitle block and later implement a TermTitle block.

--edit Explorations around Query Title here: #27989

@mtias
Copy link
Member Author

mtias commented Jan 28, 2021

The initial set of high priority items is done. I think we can close this issue and keep track of further individual items separately for clarity until a full iteration again emerges.

@mtias mtias closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants