Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block patterns to the Widgets editors #26170

Open
bph opened this issue Oct 15, 2020 · 12 comments
Open

Add block patterns to the Widgets editors #26170

bph opened this issue Oct 15, 2020 · 12 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@bph
Copy link
Contributor

bph commented Oct 15, 2020

It seems with the omission of the widget title property of widgets, and the replacement of the current core widgets with blocks, that don't have titles, end users will need to use multiple steps to recreate their sidebar units, combining core/block like latest posts or calendar with a heading block (=title) to display in the sidebar.

Now that every block has its widget wrapper this seems to only work well with a group block containing heading block + paragraph block.

With block patterns available via the Inserter, themes and plugins would be able to provide the widgets as a block patterns and help their users with this.

@bph bph added the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label Oct 15, 2020
@talldan talldan added this to Inbox in Block-based Widgets Editor via automation Oct 16, 2020
@annezazu annezazu added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Oct 17, 2020
@annezazu
Copy link
Contributor

@mapk wanted to flag this for you for a design perspective as this seems like a major UX flow to get right.

@mapk
Copy link
Contributor

mapk commented Oct 19, 2020

Thanks for the ping, @annezazu! Overall moving to blocks and helping users become accustomed with blocks is our goal here.

Block patterns can help as @bph points out when trying to combine blocks, or even just trying to establish a nice layout. I'm all for this. I remember @justintadlock pointing this out too.

Currently, we've just merged in Reusable blocks. Let's get a Patterns tab in there now too.

Screen Shot 2020-10-19 at 1 36 12 PM

@mapk mapk added the Needs Dev Ready for, and needs developer efforts label Oct 19, 2020
@talldan talldan moved this from Inbox to Needs dev in Block-based Widgets Editor Jan 6, 2021
@talldan talldan added the [Type] Enhancement A suggestion for improvement. label Jan 6, 2021
@noisysocks
Copy link
Member

If this is easy to implement then let's do it. If not, we could consider leaving it out of v1 of the widgets editor.

@noisysocks noisysocks moved this from Needs dev to Maybe later in Block-based Widgets Editor Apr 19, 2021
@noisysocks noisysocks changed the title Allow for block pattern in Widget Screen Add block patterns to the Widgets editors Jul 7, 2021
@critterverse
Copy link
Contributor

Hi all! I just wanted to add to this discussion that I think introducing patterns would be a great addition to the widget editors now that we’re looking ahead towards further enhancements for the block-based editing experience.

It would be really helpful for themes to be able to supply their own widgets patterns, which would help resolve some of the hiccups we’ve seen with the way certain themes like Twenty Twenty-One handle the flow of content within a widget area. Design contributors could also potentially submit universal widget patterns to the new Pattern Directory. Ideally, the directory could showcase patterns that mirror “traditional” widget layouts (a grouped lockup with a widget and title above) as well as other interesting layouts that are newly possible with blocks.

Maybe there could even be a new category introduced in the Pattern Directory for widgets, but I would defer to others who have been more closely involved with the development of the directory on how we could best incorporate widget patterns into the existing structure there.

An early sketch of how the inserter might look to help get the discussion going:

widget-patterns

Note that the "tip" section typically appears at the bottom of the inserter but could potentially be made more prominent somehow in order to help direct users towards the Pattern tab. Also note that Reusable blocks may be introduced into the widgets editors as well (#32952), which would introduce a third tab alongside "Blocks" and "Patterns."

@kjellr
Copy link
Contributor

kjellr commented Jul 7, 2021

Maybe there could even be a new category introduced in the Pattern Directory for widgets, but I would defer to others who have been more closely involved with the development of the directory on how we could best incorporate widget patterns into the existing structure there.

Interesting suggestion. If we did this, I do think a separate category would make sense  — many (the majority?) of patterns in the directory will likely look weird in a sidebar for example, so I like the idea of having a dedicated category for sidebar-optimized widgets.

@shaunandrews
Copy link
Contributor

shaunandrews commented Jul 7, 2021

Having patterns available from the new widget screen seems like a big bonus for using blocks; I'd love to see it happen.

I'm not entirely sure about adding a "Widgets" category to the directory, though. Instead I think it might make more sense to add multiple categories like "Sidebar" and "Footer." Then, we can use a "Widget" tag (and Block Scope) to help provide context to the patterns in those categories.

@critterverse
Copy link
Contributor

Instead I think it might make more sense to add multiple categories like "Sidebar" and "Footer." Then, we can use a "Widget" tag (and Block Scope) to help provide context to the patterns in those categories.

This makes much more sense. Thanks for weighing in @shaunandrews and @kjellr!

@draganescu
Copy link
Contributor

draganescu commented Sep 7, 2021

So effectively "enabling" patterns is just adding the

array( 
			'__experimentalBlockPatterns'          => WP_Block_Patterns_Registry::get_instance()->get_all_registered(),
			'__experimentalBlockPatternCategories' => WP_Block_Pattern_Categories_Registry::get_instance()->get_all_registered(),
		)

configuration to the initialization of the widgets editor.

However we don't support entity based blocks, so patterns such as the ones in the "Query" category won't work. So the main task here is to see whats up with the reusable and FSE blocks keeping them from working, see #32952.

@ndiego
Copy link
Member

ndiego commented Oct 19, 2021

Is there any active work being done on this? Patterns really need to be available from the block based widgets screen.

@noisysocks
Copy link
Member

noisysocks commented Jan 27, 2022

@draganescu is correct. It's easy to fix this but we're blocked by #32952 which is more involved.

Just noting that we also will need to implement this for the inserter in the widgets customizer section.

@noisysocks noisysocks added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Inserter The main way to insert blocks using the + button in the editing interface and removed [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jan 27, 2022
@JTorresConsulta
Copy link

What's going on 6.1 ?
Why can't I add reusable patterns to widgets blocks !?

@JTorresConsulta
Copy link

At this moment Wordpress has become a frustration factory

You cannot use widgets in the block editor
You also can't use blocks in the widget editor

LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

No branches or pull requests