Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome: Exempt mobile from sidebar toggled state persistence #2816

Closed
aduth opened this issue Sep 27, 2017 · 0 comments · Fixed by #3331
Closed

Chrome: Exempt mobile from sidebar toggled state persistence #2816

aduth opened this issue Sep 27, 2017 · 0 comments · Fixed by #3331
Assignees
@jorgefilipecosta
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
Beta 1.7

Comments

@aduth
Copy link
Member

aduth commented Sep 27, 2017

Related: #2462 (specifically #2462 (comment))

While sidebar toggling makes sense to persist for larger displays, in the case of smaller viewports where the sidebar occupies the entire screen, we should ensure that persistence does not apply, and that a refresh resets the sidebar to be dismissed.
@aduth aduth added General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices [Type] Task Issues or PRs that have been broken down into an individual action to take labels Sep 27, 2017
@karmatosed karmatosed added this to the Beta 1.7 milestone Nov 2, 2017
@jorgefilipecosta jorgefilipecosta self-assigned this Nov 2, 2017
@jorgefilipecosta jorgefilipecosta mentioned this issue Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Beta 1.7
Development

Successfully merging a pull request may close this issue.

Don't load isSidebarOpened preference from localStorage on mobile. WordPress/gutenberg
3 participants
@karmatosed @aduth @jorgefilipecosta