Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify template part toolbar and align with reusable blocks #28659

Closed
jameskoster opened this issue Feb 2, 2021 · 4 comments
Closed

Simplify template part toolbar and align with reusable blocks #28659

jameskoster opened this issue Feb 2, 2021 · 4 comments
Assignees
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts

Comments

@jameskoster
Copy link
Contributor

The latest work done to improve the reusable block UX yielded an update to the toolbar:

These updates can be ported to template parts as well to promote consistency across similar site building components:

For now I think it makes sense to restrict template part switching so that it is only possible to switch one template part for another. Transformations introduce further complexities and questions that I do not think we're quite ready to answer yet.

I begun work on this in #27397 and there is more context in the discussion there.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts [Block] Template Part Affects the Template Parts Block labels Feb 2, 2021
@jameskoster jameskoster linked a pull request Feb 2, 2021 that will close this issue
@mtias
Copy link
Member

mtias commented Feb 3, 2021

Also noting that the dropdown would need to account for patterns once we have them #27575

@Addison-Stavlo
Copy link
Contributor

Noting we should probably have the renaming input that is currently in that toolbar moved somewhere accessible like the block inspector sidebar. Left a comment/idea on that issue for updating the block inspector - #27875 (comment)

@mtias
Copy link
Member

mtias commented Feb 6, 2021

Yes, it should align with reusable blocks there too.

@mtias
Copy link
Member

mtias commented Mar 3, 2021

With the decision that the "switching of template parts to another template part" is not a common path to warrant such a prominent space, this can be considered finished.

@mtias mtias closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants