Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Block: Change "Inherit query from URL" language #31113

Closed
annezazu opened this issue Apr 23, 2021 · 4 comments
Closed

Query Block: Change "Inherit query from URL" language #31113

annezazu opened this issue Apr 23, 2021 · 4 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 23, 2021

What problem does this address?

This came up as part of the fifth call for testing for the FSE Outreach program from @getdave and from a member of the Japanese WordPress community:

Inherit query from URL – this wording needs to be made less technical. Perhaps just “Use default query items for this page”.

I thought that if difficult to understand the language, such as "inherited a query from URL".

It is hard to understand the words, Query, Global Query.

What is your proposed solution?

Here are some ideas:

  • Dave suggested “Use default query items for this page”.
  • Use default options
  • Use default settings
  • Use default query
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Apr 23, 2021
@Sandstromer
Copy link

My personal opinion would be for the Query Block to default initially to the "Inherit query from URL" state like it does now but there would be no mention of inheriting the query or using default query.
So, instead of deselecting this, the user would select an option something like "Customize the query" to change the query arguments.

Doing this the other way round feels more natural to me, and possibly easier for a non-dev user to understand?

@aristath
Copy link
Member

Some background here:
Instead of a switch the initial PR had a checkbox to "customize the query". The checkbox was then replaced by a switch, and in the switch it made more sense to change the label to reflect what it does.
The Query block was always considered a developer tool and AFAIK the plan was to allow user interaction with it via variations without actually exposing the query block itself. With that in mind, the language of the switch was more developer-oriented than what users would expect.

Using the term "default" would make sense, and if we do plan to expose the block to end-users, then yes, we need to change the label.

@priethor
Copy link
Contributor

priethor commented May 7, 2021

It's worth noting that this came up during the WP 5.8 FSE Go/No-go demo as well.

@ntsekouras
Copy link
Contributor

Resolved here: #32694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants