Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Insertion Flows #31153

Open
11 of 22 tasks
priethor opened this issue Apr 23, 2021 · 3 comments
Open
11 of 22 tasks

Pattern Insertion Flows #31153

priethor opened this issue Apr 23, 2021 · 3 comments
Labels
[Feature] Inserter [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns [Type] Tracking Issue For issues used to track large changes across the codebase

Comments

@priethor
Copy link
Contributor

priethor commented Apr 23, 2021

Insertion UI

Discoverability

Pattern availability and restricting

Contextual suggestions (broader discussion in #27575)

Search

Connection with w.org directory

@priethor priethor added [Feature] Inserter [Type] Tracking Issue For issues used to track large changes across the codebase [Feature] Patterns [Feature] Pattern Directory The Pattern Directory, a place to find patterns labels Apr 23, 2021
@ramonjd
Copy link
Member

ramonjd commented May 17, 2021

Looking for opinions here: would it make sense to be able to tell the block editor plugin not to register its own patterns or update core patterns?

Let's just say we want to be able offer our own library of patterns, or only those available in a WordPress install.

Other than keeping track of every block name that Gutenberg registers, and then manually unregistering them, how could we disable them?

I see two options (assuming the idea itself is sound):

  1. Add an apply_filters( 'register_gutenberg_patterns', true ) and apply_filters( 'update_core_patternscheck', true ) for example
  2. Standardize patterns names registered by the plugin so we can filter them out more reliably: currently we're registering query/* and social-links/shared-background-color.

I think it's especially important given the comment in the file:

 * Deactivate the legacy patterns bundled with WordPress, and add new block patterns for testing.

For experimental patterns, I think we should be able to opt-out.

@priethor
Copy link
Contributor Author

Hi @ramonjd! Given this issue is more focused on the pattern insertion experience within post and template editors, I think it would be more effective to create its own issue to discuss this more in detail, as suggested in the related PR. In any case, I think your proposal makes sense, but I would love to hear @ntsekouras' opinion as well.

@ramonjd
Copy link
Member

ramonjd commented May 17, 2021

Thanks for the quick feedback @priethor! I'll do as you suggest, and create a new issue to direct discussion there. Sorry for hijacking this issue!

@mtias mtias mentioned this issue Jun 30, 2021
56 tasks
@noisysocks noisysocks added this to 📥 To do in WordPress 5.9 Must-Haves via automation Oct 21, 2021
@noisysocks noisysocks moved this from 📥 To do to 📋 Overviews in WordPress 5.9 Must-Haves Oct 21, 2021
@noisysocks noisysocks removed this from 📋 Tracking issues in WordPress 5.9 Must-Haves Nov 18, 2021
@mtias mtias changed the title Pattern insertion tracking issue Pattern Insertion Flows Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns [Type] Tracking Issue For issues used to track large changes across the codebase
Projects
None yet
Development

No branches or pull requests

2 participants