Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer Widgets: small bugs and styling tweaks #31958

Closed
critterverse opened this issue May 18, 2021 · 6 comments
Closed

Customizer Widgets: small bugs and styling tweaks #31958

critterverse opened this issue May 18, 2021 · 6 comments
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets.

Comments

@critterverse
Copy link
Contributor

Hi all, I just completed the recent Widgets Call for Testing and compiled a list of bugs I noticed within the Customizer Widgets editor. I'm adding images as external links to keep this list easy to read!

Block-related:

Legacy widget-related:

  • Legacy widgets should switch back to “preview” mode when not selected

General:

  • When adding a block, sometimes an extra “add” button appears on top of the block on the left edge of the screen
  • It's confusing that the “patterns” tab is available within the Inserter but appears empty — could we just remove the tab entirely for now?
@critterverse critterverse added the [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. label May 18, 2021
@noisysocks noisysocks added this to Inbox in Block-based Widgets Editor via automation May 19, 2021
@noisysocks noisysocks moved this from Inbox to Needs dev in Block-based Widgets Editor May 19, 2021
@kevin940726 kevin940726 self-assigned this May 20, 2021
@kevin940726 kevin940726 moved this from Needs dev to Issues in progress in Block-based Widgets Editor May 20, 2021
@kevin940726
Copy link
Member

kevin940726 commented May 20, 2021

Thanks for testing! They're really helpful 😍. I did a triage for some of them below:

Paragraph block: Seeing some overlapping popover menus for link / inline text color

I'm seeing this too in the post editor though, can you confirm it's customizer only? Or maybe we can open a separate issue for it.

image

Navigation block: modal doesn’t open from the “block navigation” icon in the toolbar

It's opening during my testing though, can you confirm it's still happening on trunk?

Kapture.2021-05-21.at.01.38.25.mp4

Group block: Focused outline is overlapping with “add block” button — can we hide the "add" button that's appearing within the group?

I'm not seeing this either. Could you provide reproduction steps?

image

Legacy widgets should switch back to “preview” mode when not selected

I can't reproduce this either, do you have reproduction steps?

It's confusing that the “patterns” tab is available within the Inserter but appears empty — could we just remove the tab entirely for now?

I'm not seeing this on trunk either, maybe it has been fixed not long ago?

image

@critterverse
Copy link
Contributor Author

Thanks so much for going through all of these notes @kevin940726, and sorry there were a few false alarms! 🙈

Double checked all, and everything not mentioned below is working as intended 😁

Overlapping pop-up menus:
Confirming that this does happen in the post editor as well and opened a new issue, #32221

Group block "add" button:
I am still seeing this overlapping issue — here's a quick video.

group-block-add.mov

@kevin940726
Copy link
Member

@critterverse Thanks for confirming!

I also found out that the Group block "add" button issue can be reproduced in the post editor as well. I'm not sure whether it's the expected behavior though. Also seems like it can only be reproduced when the last block is an image block.

Kapture.2021-05-26.at.17.49.45.mp4

@critterverse
Copy link
Contributor Author

I believe it is the expected behavior for container blocks like Group, Columns, etc have an extra add button that allow you to insert a new block within the container (so my suggestion to hide the add button wasn’t a great one).

But I'm unable to recreate the focus outline overlapping issue in the post editor, even within a narrow Column area. I think that bug is unique to the Customizer but I could be wrong!

post-editor-appender.mov

@kevin940726
Copy link
Member

@critterverse This is also an issue in other editors (widgets screen) other than the post editor as well. The issue is because these editors don't load some of the styles loaded in the post editor. I don't have any idea how to fix it yet, might need to come back to it later 🤔.

@kevin940726 kevin940726 moved this from Issues in progress to Needs dev in Block-based Widgets Editor Jun 4, 2021
@kevin940726 kevin940726 removed their assignment Jun 4, 2021
@noisysocks
Copy link
Member

What's left here? Can we close the issue?

Block-based Widgets Editor automation moved this from Needs dev to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets.
Projects
No open projects
Development

No branches or pull requests

3 participants