Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance Widgets editor: edits to widget area containers #31959

Closed
critterverse opened this issue May 18, 2021 · 3 comments · Fixed by #32262
Closed

Appearance Widgets editor: edits to widget area containers #31959

critterverse opened this issue May 18, 2021 · 3 comments · Fixed by #32262
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php.

Comments

@critterverse
Copy link
Contributor

critterverse commented May 18, 2021

Hi all, I just completed the recent Widgets Call for Testing and compiled a list of bugs I noticed within the Appearance Widgets editor. I'm adding images as external links to keep this list easy to read!

Here are a few things I noticed about the widget areas containers:

widget-area-containers

  • The block icon is misaligned (spotted in this blog post by @shaunandrews)
  • There's an extra line at the bottom of the ellipses menu that can be removed
  • The ellipses menu contains an option for adding the widget area as a Reusable block, which I think should be removed. It works but leads to weird results when you try to insert the block elsewhere 😂
  • It’s confusing that the widget areas that are in use are closed when you first enter the screen, and I imagine some users might think that their content disappeared. Could we have empty areas default to closed and areas with items default to open/expanded? (Inactive widgets, if that section remains, could default to closed)
@critterverse critterverse added the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label May 18, 2021
@critterverse
Copy link
Contributor Author

Not related to the widget area containers but adding one small styling tweak for the Appearance screen in case it's possible to fit it in here with these other changes. Could we adjust the spacing between the Update button and Settings toggle to match the post editor? Should be 16px between:

button-spacing

@talldan
Copy link
Contributor

talldan commented May 27, 2021

#32262 fixes most of this—it's a bug that the widget area has a toolbar.

The block icon is misaligned (spotted in this blog post by @shaunandrews)

I think this is a bug not just limited to the widget editor. I'll move that and the header adjustments to separate issues (#32263).

edit: It looks like the misaligned block icon has been resolved by a someone else (thank you mystery person).

@critterverse
Copy link
Contributor Author

Nice. I split the only remaining bit of this issue off into #32278 (as a potential future-facing improvement) and will close this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants