New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg demo shows a full-width Cover Image, but this option is not present in the UI #3516

Closed
nylen opened this Issue Nov 16, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@nylen
Copy link
Member

nylen commented Nov 16, 2017

2017-11-16t15 57 06 0800

It appears that it is no longer possible to create a full-width cover image via the editing interface. Maybe I am just missing the way to do it, but if it is really no longer possible, then this feature should be removed from the demo content and its CSS rules should be removed.

@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Nov 16, 2017

In my opinion it should definitely be possible. This is pretty common design pattern and it would be inline with image block.

See also #2650.

@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Nov 16, 2017

@nylen You can set 'wide-images' => true, in add_theme_support( 'gutenberg' ) and after that you can set full width cover image. But alignwide or alignfull are still missing in the markup. Those should be added.

@samikeijonen samikeijonen referenced this issue Nov 16, 2017

Merged

Update cover image markup and CSS #3444

2 of 3 tasks complete
@nylen

This comment has been minimized.

Copy link
Member

nylen commented Nov 17, 2017

I'm not aware of the context behind making this available on a per-theme basis, but it sounds sensible.

So I think the only thing to do here is to remove the full-width cover image from the demo content, since this can't be recreated on a standard install.

@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Nov 17, 2017

I'm not aware of the context behind making this available on a per-theme basis, but it sounds sensible.

It's because Gutenberg can't know is there room for full width or wide, and what that even means on theme by theme. There can be sidebars in the left or right etc.

@mtias

This comment has been minimized.

Copy link
Contributor

mtias commented Nov 20, 2017

Closing as duplicate of #2595.

@pipskidoodle

This comment has been minimized.

Copy link

pipskidoodle commented Nov 27, 2018

/**

  • Register support for Gutenberg wide images in your theme
    */
    function mytheme_setup() {
    add_theme_support( 'align-wide' );
    }
    add_action( 'after_setup_theme', 'mytheme_setup' );

https://weblines.com.au/gutenberg-blocks-wide-alignment-full-width/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment